Skip to content

Feature/network first option#25

Open
mpatafio wants to merge 10 commits into
Exilz:masterfrom
mpatafio:feature/network_first_option
Open

Feature/network first option#25
mpatafio wants to merge 10 commits into
Exilz:masterfrom
mpatafio:feature/network_first_option

Conversation

@mpatafio

Copy link
Copy Markdown

Hi @Exilz !

you lib is great!

I was trying to manage a real use case in the mobile world (and not only in it I guess): make a request perform a network first operation rather than check cache availability at the beginning of the flow. This will allow clients to try to refresh cache without altering the service definition, also because it wasn't possibile by defining any kind of middleware. This way clients are able to use the same service (then same cache) and by customising service options they can make the request behave accordingly to the above need.

Hope it makes sense.

Regards

@Exilz

Exilz commented Apr 15, 2019

Copy link
Copy Markdown
Owner

Hi,
thanks for the contribution.

This is something I thought about adding, too.

Could you make sure not to commit your .idea folder ? 😅 You can add it to the .gitignore as well.

@mpatafio

Copy link
Copy Markdown
Author

Removed idea files 👍 thanks

@mpatafio

mpatafio commented Apr 16, 2019

Copy link
Copy Markdown
Author

Hi @Exilz,

I've removed the stuff you suggested, then updated the Readme and bumped the minor version. The PR is ready to be merged if you want.

@mpatafio

mpatafio commented May 9, 2019

Copy link
Copy Markdown
Author

@Exilz up!

@Villar74

Villar74 commented Jul 9, 2019

Copy link
Copy Markdown

@Exilz up please)

@chicio

chicio commented Jul 22, 2019

Copy link
Copy Markdown

@Exilz up pleasssseeeeeeeee!!!

@Villar74

Copy link
Copy Markdown

don't leave uuuus XD @Exilz

@Villar74

Villar74 commented Aug 7, 2019

Copy link
Copy Markdown

@Exilz merge pls

Comment thread .gitignore Outdated
Comment thread .watchmanconfig Outdated
Comment thread dist/drivers/sqlite.js
Comment thread dist/index.js
Comment thread dist/index.js
Comment thread dist/index.js
Comment thread dist/index.js
Comment thread dist/index.js
Comment thread src/index.ts
Comment thread tsconfig.json Outdated
@Exilz

Exilz commented Aug 7, 2019

Copy link
Copy Markdown
Owner

Thanks for the code review @Villar74 . I added some comments, too.
I wouldn't change anything on the generated javascript file. Let typescript do its thing.

Once you've made the requested changes, let's squash your commits before merging them.

@Villar74

Villar74 commented Aug 7, 2019

Copy link
Copy Markdown

Once you've made the requested changes, let's squash your commits before merging them.

@Exilz You talked to @mpatafio here?

@Exilz

Exilz commented Aug 7, 2019

Copy link
Copy Markdown
Owner

@Villar74 yes 😄

@mpatafio

mpatafio commented Aug 7, 2019

Copy link
Copy Markdown
Author

Hi guys!

Thank you for the comments! I’ll fix them as soon as I’ll come back from holiday (likely 21st of August)

@mpatafio

Copy link
Copy Markdown
Author

Hi guys! Thank you for the code review, I've resolved all the comments (apart the generated js files). Now I guess it can be merged. Just one thing for @Exilz: the image showing the flow of the library should be changed according to this new flow (conditioned by network first option), I changed the documentation, cannot do the same for such image. Thank you!

@Villar74

Copy link
Copy Markdown

@Exilz up

@mpatafio

Copy link
Copy Markdown
Author

are you still there guys?

@Villar74

Villar74 commented Nov 5, 2019

Copy link
Copy Markdown

@Exilz wake up pls, bro)

@Villar74

Villar74 commented Dec 3, 2019

Copy link
Copy Markdown

@Exilz Maxime, merge pls

Repository owner deleted a comment from Soumya6Tiwari Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants