fix(ci): repair main CI — clippy 1.97 lint + stale vendored-dep review - #298
Merged
Conversation
Two time/toolchain-drift failures broke every ci.yml job on main (none
related to the recent Dependabot action bumps):
1. rust-parser (clippy): clippy 1.97's question_mark lint now errors on
the `else if let Some(v6) … else { return None }` block in
rust/aegis-parser/src/policy.rs. Applied clippy's own suggested
rewrite: `parse_ipv6(&ip_part)?.to_string()`. Semantically identical;
local clippy + fmt + tests pass.
2. vendored_dependency_contract (test / sanitizers×3 / coverage /
readiness×2 / QEMU-ARM64 — 8 jobs, all failing on this single test):
the TweetNaCl vendored-dep review went stale (last_reviewed 2026-05-07,
90-day interval, age 94d). src/tweetnacl.c is byte-identical since that
review (git log: 0 commits touching it), so this is a calendar
re-attestation of unchanged, still-pinned upstream — not a code change.
Bumped last_reviewed to 2026-08-09; check passes locally.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
main's CI went red from time/toolchain drift (not the Dependabot action bumps — those are version-only). All 9 failing jobs trace to two root causes:question_marklint now errors onrust/aegis-parser/src/policy.rs:345→ applied clippy's own suggested?rewrite (semantically identical; clippy/fmt/tests green locally).vendored_dependency_contractstaleness — fails 8 jobs (test, sanitizers ×3, coverage, readiness ×2, QEMU-ARM64), all on this one test. The TweetNaCl review lapsed (last_reviewed 2026-05-07, 90d interval, 94d old).src/tweetnacl.cis byte-identical since that review (git-verified, 0 commits), so bumpinglast_reviewedto 2026-08-09 is a re-attestation of unchanged pinned upstream, not a code change.Verified locally: clippy exit 0, vendored check passes. This unblocks #293 (which was only inheriting main's red).
🤖 Generated with Claude Code