Create Shared Elements Transition from All/RoomSessionsFragment to SessionDetailFragment#564
Open
e10dokup wants to merge 6 commits into
Open
Create Shared Elements Transition from All/RoomSessionsFragment to SessionDetailFragment#564e10dokup wants to merge 6 commits into
e10dokup wants to merge 6 commits into
Conversation
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { | ||
| setEnterSharedElementCallback(sharedElementCallback) | ||
| } | ||
|
|
There was a problem hiding this comment.
| Unexpected blank line(s) before “}” |
| fun findFragmentByPosition(viewPager: ViewPager, position: Int): SessionDetailFragment { | ||
| return instantiateItem(viewPager, position) as SessionDetailFragment | ||
| } | ||
|
|
There was a problem hiding this comment.
| Unexpected blank line(s) before “}” |
| } | ||
|
|
||
| fun start(activity: Activity, session: Session, sharedElement: Pair<View, String>) { | ||
| val options = ActivityOptionsCompat.makeSceneTransitionAnimation(activity, sharedElement) |
There was a problem hiding this comment.
| Exceeded max line length (100) |
| putExtra(EXTRA_TRANSITION_NAME, sharedElement.second) | ||
| } | ||
| } | ||
|
|
There was a problem hiding this comment.
| Unexpected blank line(s) before “}” |
Member
|
👀 |
takahirom
reviewed
Feb 3, 2018
| @Inject lateinit var viewModelFactory: ViewModelProvider.Factory | ||
| @Inject lateinit var drawerMenu: DrawerMenu | ||
|
|
||
| private var backPressed = false |
Member
There was a problem hiding this comment.
Please comment why this need 🙏
Contributor
Author
There was a problem hiding this comment.
I think it will not be needed..., I will remove this on next commit. Thanks.
takahirom
reviewed
Feb 3, 2018
|
|
||
| binding.toolbar.setNavigationOnClickListener { activity?.finish() } | ||
|
|
||
| binding.speakerSummary.viewTreeObserver.addOnPreDrawListener( |
Member
There was a problem hiding this comment.
Can you add an extension method to ViewExt?
fun View.addOnetimeOnPreDrawListener(listener:()->Unit)
takahirom
reviewed
Feb 3, 2018
| } | ||
|
|
||
| @TargetApi(Build.VERSION_CODES.LOLLIPOP) | ||
| private val sharedElementCallback = object : SharedElementCallback() { |
Member
There was a problem hiding this comment.
I have a question 🙋
SharedElementCallback is not contained API Level 19.
Is this not crash on API Level 19?
takahirom
reviewed
Feb 3, 2018
|
|
||
| binding.toolbar.setNavigationOnClickListener { activity?.finish() } | ||
|
|
||
| binding.speakerSummary.viewTreeObserver.addOnPreDrawListener( |
Member
There was a problem hiding this comment.
rkowase
reviewed
Feb 3, 2018
| ViewModelProviders.of(activity!!, viewModelFactory).get(SessionDetailViewModel::class.java) | ||
| } | ||
|
|
||
| val speakerSummary: SpeakersSummaryLayout |
Contributor
There was a problem hiding this comment.
[nits] Do you use this property?
Contributor
Author
There was a problem hiding this comment.
Thanks! I forgot to remove this property..., I will remove on next commit.
e10dokup
force-pushed
the
feature/450_session_transition
branch
from
ceddbbe to
f0b84f5
Compare
e10dokup
force-pushed
the
feature/450_session_transition
branch
from
f0b84f5 to
1d73ffe
Compare
Contributor
Author
|
@takahirom @rkowase Thanks for your reviews! I added fix commits to respond your comments. |
e10dokup
force-pushed
the
feature/450_session_transition
branch
from
e73e923 to
dd9b57c
Compare
e10dokup
force-pushed
the
feature/450_session_transition
branch
from
dd9b57c to
17d0220
Compare
| && Build.VERSION.SDK_INT >= Build.VERSION_CODES.LOLLIPOP) { | ||
| initViewTransitions(view) | ||
| } | ||
|
|
There was a problem hiding this comment.
| Unexpected blank line(s) before “}” |
Member
|
I'm sorry. |
Contributor
Author
|
@takahirom Thanks. I'm sorry I create poor PR... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
（以下日本語で失礼します）
SessionDetailFrgamentからAll/RoomSessionsFragmentへの戻りのTransactionを実装したかったのですが、SessionDetailActivityのViewPagerに入るSessionDetailFragmentのSessionが全セッションとなっているため、RoomSessionsFragmentとリストの整合性がうまく取れず綺麗に遷移できなかったため、現状は戻りに関してはアニメーションをしないようにしています…。
Links
Screenshot