fix: octopus PDF model with public note and subtotal - #39527
Open
thomastraversierpro-alt wants to merge 6 commits into
Open
fix: octopus PDF model with public note and subtotal#39527thomastraversierpro-alt wants to merge 6 commits into
thomastraversierpro-alt wants to merge 6 commits into
Conversation
frederic34
reviewed
Aug 14, 2026
| // blanks the standard columns through its hooks (pdf_getlineqty, pdf_getlineprogress, ...), | ||
| // but it knows nothing about the BTP situation columns added below. Its title, subtotal and | ||
| // free text lines carry no amount either, so they must be detected here too. | ||
| $usecustomsubtotal = isModEnabled('subtotal'); |
Member
There was a problem hiding this comment.
is it a fix for an external module (subtotal) ?
perhaps make separate PR for each problem's fix
There was a problem hiding this comment.
The PR now only covers the standard subtotals module, the custom one has been
removed from it.
thomastraversierpro-alt
marked this pull request as ready for review
August 17, 2026 14:07
Add PHPDoc annotations for better code clarity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FIX Octopus invoice PDF model: public note position, page break and Subtotals support
Three issues fixed in
pdf_octopus.modules.php:0values in the amount columns, and subtotal lines were neither displayed nor computed.Before
After