Subtotals predefined titles and texts - #39337
Open
frederic34 wants to merge 69 commits into
Open
Conversation
Design doc for adding a dictionary of predefined phrases usable in title-line descriptions of the subtotals module.
…bles on module init
…nk-option write, unescaped option value, entity-scoped dictionary query
Button entries built without a 'text' key (e.g. the subtotals module's "Add title line"/"Add subtotal line" dropdown) triggered a PHP warning on the multi-button branch, which already guarded every other optional key the same way.
Adds a spec for extending the googleapi custom module with a new ECM tab that browses/manages the connected user's Google Drive content.
9-task plan extending the googleapi custom module: Drive service helper, tab registration, tab page, tree/list/download AJAX endpoints, and upload/rename/delete actions.
The final whole-branch review found the plan wrongly assumed jqueryFileTree.js is loaded globally by Dolibarr core; it must be pushed into each page's own \$morejs array. Documented the actual requirement for future reference.
…ictionary Design doc for a third subtotals-module line kind (qty=0, no level, no closing line) with its own multi-line predefined-text dictionary, building on the predefined-phrases dictionary infrastructure.
…itable text-line content
Member
Author
This is sample text, it can be anything else |
eldy
reviewed
Aug 5, 2026
eldy
reviewed
Aug 5, 2026
eldy
reviewed
Aug 5, 2026
eldy
reviewed
Aug 5, 2026
eldy
added
PR to fix - See feedback in comments
…to subtotals-predefined-phrases
frederic34
removed
the
PR mixing structure and code change
frederic34
removed
the
PR to fix - See feedback in comments
…to subtotals-predefined-phrases
…ined-phrases # Conflicts: # htdocs/core/tpl/subtotal_edit.tpl.php
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.