Fix #31471 translate CostPrice and PriceBaseType on import field list#38922
Open
pixodeo wants to merge 1 commit into
Open
Fix #31471 translate CostPrice and PriceBaseType on import field list#38922pixodeo wants to merge 1 commit into
pixodeo wants to merge 1 commit into
Conversation
…eld list import.php loadLangs only loaded exports/compta/errors, so labels coming from modProduct / modService import_fields_array that resolve to keys in products.lang (PriceBaseType) and margins.lang (CostPrice) stayed in English on a French install. Add 'products' and 'margins' to the loaded set so the import field picker shows the translated label everywhere else the user sees the product card. Signed-off-by: Dolicraft <contact@dolicraft.com>
the-dolibear-bot
Bot
added
the
Issue for v18 maintenance Team
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31471.
htdocs/imports/import.php only loaded exports/compta/errors so labels coming from modProduct and modService import_fields_array that resolve to keys in products.lang (PriceBaseType) and margins.lang (CostPrice) stayed in English on a French install. Add 'products' and 'margins' to the loadLangs call so the import field picker shows the translated label that the rest of the product card already uses.