Fix reservoirs outside rivers#777
Merged
Merged
Conversation
LuukBlom
requested changes
Jul 2, 2026
LuukBlom
reviewed
Jul 6, 2026
LuukBlom
left a comment
LuukBlom
left a comment
Collaborator
There was a problem hiding this comment.
Nice!
Code LGTM, only very minor comments left about the tests
LuukBlom
approved these changes
Jul 7, 2026
|
LuukBlom
added a commit
that referenced
this pull request
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #724
Explanation
Added ability for users to exclude reservoirs that are outside of the river network (no cells overlapping) by adding an exclude_outside_reservoirs flag, which is by default set to False.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.