Fix unit conversion after reduction - #983
Merged
Merged
Conversation
JoostBuitink
requested changes
Jul 13, 2026
JoostBuitink
left a comment
Contributor
There was a problem hiding this comment.
This did not fix the issue, as the function is still dispatching on
Line 313 in af8225f
This is because of the following:
typeof(reducer_(vector)) = Vector{Float64} while from_SI expects an AbstractFloat.
I'll create a separate issue to describe how to add this functionality to the tests
Contributor
Author
|
I added an |
Contributor
|
Thanks that did indeed solve this! |
JoostBuitink
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue addressed
Fixes #974
Explanation
Some reducers created
Generatorobjects instead of aFloat64orVector{Float64}, which then dispatched to the fallback method offrom_SIas @JoostBuitink mentioned.@JoostBuitink regarding the testing you mentioned: can you make an issue with an overview of what should be tested and ideally also which test models can be used for it? See also #864.