[DOCS-14683] Add Secrets Management to MySQL source#37418
Conversation
This comment has been minimized.
This comment has been minimized.
Preview links (active after the
|
|
/review |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
🤖 Automated review by Claude. AI-generated; verify before acting.
Changes look clean and consistent with the established pattern used across other Observability Pipelines source pages (danger alert + secrets_env_var_note shortcode + tabbed Secret defaults section). Naming for the new env var (DD_OP_SOURCE_MYSQL_CONNECTION_STRING) and secret identifier (SOURCE_MYSQL_CONNECTION_STRING) follows the documented convention. The MySQL entry in environment_variables.md is correctly placed alphabetically. No blockers; no style violations in the changed lines.
Reviewed 9120747574bfc4181a578be78544c34b8dfdc4ba — workflow run
domalessi
left a comment
domalessi
left a comment
There was a problem hiding this comment.
Two minor suggestions. Otherwise, looks good!
| After you select the MySQL source in the pipeline UI: | ||
|
|
||
| 1. Enter the connection string. | ||
| 1. Enter the identifier for your URI connection string. If you leave it blank, the [default](#secret-defaults) is used. |
There was a problem hiding this comment.
| 1. Enter the identifier for your URI connection string. If you leave it blank, the [default](#secret-defaults) is used. | |
| 1. Enter the identifier for your URI connection string. If you leave it blank, the [default](#secret-defaults) applies. |
|
|
||
| Ensure you have completed the [prerequisite steps](#prerequisites) first. Then, set up the MySQL source and its environment variables when you [set up a pipeline][1]. The information below is configured in the pipelines UI. | ||
|
|
||
| <div class="alert alert-danger">For Secrets Management: Only enter the identifier for the MySQL URI connection string. Do <b>not</b> enter the actual value.</div> |
There was a problem hiding this comment.
The identifier/actual distinction is what's most important here, so I think it makes more sense to bold that.
| <div class="alert alert-danger">For Secrets Management: Only enter the identifier for the MySQL URI connection string. Do <b>not</b> enter the actual value.</div> | |
| <div class="alert alert-danger">When using Secrets Management, only enter the <b>identifier</b> for the MySQL URI connection string, not the actual value.</div> |
2 participants
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
AI assistance
Additional notes