fix(lapdog): do not crash python process when starting lapdog#393
Open
sabrenner wants to merge 1 commit into
Open
fix(lapdog): do not crash python process when starting lapdog#393sabrenner wants to merge 1 commit into
sabrenner wants to merge 1 commit into
Conversation
Yun-Kim
approved these changes
Jun 10, 2026
Yun-Kim
left a comment
Yun-Kim
left a comment
Contributor
There was a problem hiding this comment.
Looks like a harmless change at worst, are we able to reproduce the issue and confirm this solves it?
Collaborator
Author
i had previously seen this issue so yes, but haven't recently. this is more of a best-effort attempt. i'll actually try and get it to surface one more time before merging to confirm. if i can't though i'm just gonna send it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Starting lapdog with a coding agent would intermittently cause Python crashes. From investigation, it seems this happens on Python 3.13. This PR attempts to fix it by using
urllib.requestinstead ofrequests. It's also possible forking processes here has some issues and subprocessing would work better, but just attempting this for now.