Skip to content

fix: ship handler.mjs as the sole Lambda entry point #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zarirhamza wants to merge 5 commits into
base: main
Choose a base branch
from
+12 −153
Open

fix: ship handler.mjs as the sole Lambda entry point #784

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
db838ab
fix: route ESM Lambdas through handler.mjs via CJS shim
zarirhamza Jun 9, 2026
270a846
fix(layer): keep handler.js shim out of the published layer
zarirhamza Jun 9, 2026
f301d30
refactor(handler): address PR #784 review feedback
zarirhamza Jun 11, 2026
ee53944
refactor: drop CJS shim and ship handler.mjs as sole entry point
zarirhamza Jun 11, 2026
3aa51e2
refactor: drop orphaned sync loader chain; guard dist against stale a…
zarirhamza Jun 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .gitlab/scripts/publish_npm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,5 +29,4 @@ if [ -d "./dist" ]; then
rm -rf ./dist
fi
yarn build
cp ./dist/handler.cjs ./dist/handler.js
npm publish
1 change: 0 additions & 1 deletion scripts/publish_prod.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ else
rm -rf ./dist
fi
yarn build
cp ./dist/handler.cjs ./dist/handler.js
yarn publish --new-version "$NEW_VERSION"
fi

Expand Down
8 changes: 6 additions & 2 deletions scripts/update_dist_version.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,11 @@ echo "$MAIN_CONSTANTS" |
echo "$TRACE_CONSTANTS" |
sed "s/\(ddtraceVersion =\) \"\(X\.X\.X\)\"/\1 \"$DD_TRACE_VERSION\"/" > ./dist/trace/constants.js

echo "Copying handler js files"
cp src/handler.* dist/
echo "Copying handler files"
# Only handler.mjs ships as a Lambda entry point. Lambda's bootstrap resolves
# `dist/handler.handler` to handler.mjs (it falls through `.js` -> `.mjs`),
# and handler.mjs's async `load()` handles both CJS and ESM user modules, so
# a separate `.js` / `.cjs` variant is no longer needed.
cp src/handler.mjs dist/
Comment thread
lucaspimentel marked this conversation as resolved.
cp src/init.js dist/init.js
cp src/runtime/module_importer.js dist/runtime/
43 changes: 0 additions & 43 deletions src/handler.cjs
View file
Open in desktop

This file was deleted.

Loading