Adding time_signal support into scte35 delivery#313
Open
tru64master wants to merge 6 commits into
Open
Conversation
consists of replicating the existing splice_info option - scte35_11/12/13 instead of 1/2/3. We add a loop to send two EMSG packets one with a start the other a stop.
Added support for both PPO and DPO (provider advertisement and Distributor Advertisement)
Added them to .gitignore to avoid future commits of these files.
These are not exhaustive, but they do cover some additional cases that were not previously tested.
…teEmsgAhead function signature. This was added to aid debugging. No longer required.
Contributor
|
@tru64master Thanks for your contribution. SCTE-35 support is very basic, so this is probably a good improvement. Will try to look at it when I have some more time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing scte35 code allowed for splice_inserts on the basis of 1, 2 or 3 per minute. I added the ability to send time_signal commands instead each sending a start and end splice message. This is performed on the same basis - 1,2 or 3 per minute - but uses additional options to the scte35_1, scte35_2 or scte35_3 options - scte35_11, scte35_12, scte35_13 delivers Provider messages, then scte35_21/22/23 delivers Distributor messages. There will be two EMSG entries in the mp4 stream, one each for the start and stop, the PTS being calculated as start + duration. The MPD is left the same as with the existing code.