fix(api): ensure hit statuses are not mismatched on ingest#487
Open
cccs-mdr wants to merge 4 commits into
Open
fix(api): ensure hit statuses are not mismatched on ingest#487cccs-mdr wants to merge 4 commits into
cccs-mdr wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens API ingest validation for hits by normalizing inconsistent state combinations at ingest time (so assessment/escalation and escalation/status don’t drift), and aligns ODM model annotations with explicit str/| None typing for better static clarity.
Changes:
- Add ingest-time normalization in
convert_hit()to enforce assessment→escalation mapping and ensure certain escalation values implyresolvedstatus. - Emit warnings when incoming hits are auto-corrected to meet the expected state constraints.
- Update
HowlerData/related ODM model field type annotations to usestr | Noneand explicitstrfor enum-backed fields.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| api/howler/services/hit_service.py | Adds ingest-time state normalization and warning messages for mismatched assessment/escalation and escalation/status. |
| api/howler/odm/models/howler_data.py | Refines ODM model type annotations (PEP 604 unions and explicit str types for enum fields). |
Contributor
Howler API - Coverage Results
Diff CoverageDiff: origin/main...HEAD, staged and unstaged changes
Summary
Full Coverage ReportExpand |
-passing-brightgreen){kind=icon}
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
cccs-mdr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.