Skip to content

Feat/k8s kms plugin#999

Open
p0wline wants to merge 27 commits into
developfrom
feat/k8s-kms-plugin
Open

Feat/k8s kms plugin#999
p0wline wants to merge 27 commits into
developfrom
feat/k8s-kms-plugin

Conversation

@p0wline

@p0wline p0wline commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@p0wline p0wline force-pushed the feat/k8s-kms-plugin branch 2 times, most recently from c5e3675 to 2317356 Compare June 15, 2026 13:03
@p0wline

p0wline commented Jun 16, 2026

Copy link
Copy Markdown
Contributor Author

@copilot resolve the merge conflicts in this pull request

Copilot AI commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

@copilot resolve the merge conflicts in this pull request

Done — merged main (5.23.0) into this branch. The merge was clean with no conflicts. Merge commit: b634f5a.

@p0wline p0wline force-pushed the feat/k8s-kms-plugin branch 2 times, most recently from 10eef1b to dc6f4ba Compare June 16, 2026 08:59
@p0wline p0wline requested a review from Manuthor June 16, 2026 12:03
@Cosmian Cosmian deleted a comment from Copilot AI Jun 16, 2026
@p0wline p0wline closed this Jun 16, 2026
@Cosmian Cosmian deleted a comment from Copilot AI Jun 16, 2026
@p0wline p0wline reopened this Jun 16, 2026
@p0wline p0wline requested a review from Copilot June 16, 2026 13:11

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Kubernetes KMS v2 provider plugin binary (cosmian-kms-plugin) to let kube-apiserver delegate Encrypt/Decrypt operations to Cosmian KMS (via KMIP), along with documentation, test vectors, and Nix vendor-hash updates.

Changes:

  • Introduces cosmian_kms_k8s_plugin crate (gRPC service, YAML config, build-time proto generation).
  • Adds integration docs + MkDocs navigation entry for the Kubernetes plugin.
  • Adds a KMS test vector runner entry for the plugin flow and updates Nix expected vendor hashes / Cargo.lock.

Reviewed changes

Copilot reviewed 18 out of 19 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
nix/expected-hashes/ui.vendor.non-fips.sha256 Updates UI vendor hash for Nix builds.
nix/expected-hashes/ui.vendor.fips.sha256 Updates UI vendor hash for Nix builds.
nix/expected-hashes/server.vendor.static.sha256 Updates server vendor hash for Nix builds.
nix/expected-hashes/cli.vendor.linux.sha256 Updates CLI vendor hash for Nix builds.
documentation/mkdocs.yml Adds the Kubernetes plugin page to site navigation.
documentation/docs/integrations/kubernetes_kms_plugin.md New integration documentation for the Kubernetes KMS v2 plugin.
crate/test_kms_server/src/vector_runner.rs Registers a new test vector for the plugin wrap/unwrap flow.
crate/clients/k8s_plugin/src/service.rs Implements the KMS v2 gRPC service delegating to KmsClient KMIP Encrypt/Decrypt.
crate/clients/k8s_plugin/src/main.rs Adds CLI entrypoint: loads config, binds Unix socket, serves tonic gRPC.
crate/clients/k8s_plugin/src/kmsv2.proto Adds the Kubernetes KMS v2 proto definition (Apache 2.0 source).
crate/clients/k8s_plugin/src/integration_tests.rs New end-to-end test: spins up test KMS + plugin and checks Status/Encrypt/Decrypt.
crate/clients/k8s_plugin/src/error.rs Introduces plugin error type and maps it to tonic::Status.
crate/clients/k8s_plugin/src/config.rs Adds YAML config schema + loader for the plugin.
crate/clients/k8s_plugin/Cargo.toml New crate manifest (deps: tonic/prost/protox, serde_yaml, etc.).
crate/clients/k8s_plugin/build.rs Generates tonic bindings from the proto at build time (protox-based).
Cargo.toml Adds the new crate to the workspace members list.
Cargo.lock Locks new dependencies pulled in by the plugin (tonic-build/protox/etc.).

Comment thread crate/clients/k8s_plugin/src/config.rs
Comment thread crate/clients/k8s_plugin/build.rs
Comment thread crate/clients/k8s_plugin/src/main.rs
Comment thread crate/clients/k8s_plugin/src/main.rs Outdated
Comment thread documentation/docs/integrations/kubernetes_kms_plugin.md Outdated
Comment thread crate/clients/k8s_plugin/src/integration_tests.rs Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 12 comments.

Comment thread crate/clients/k8s_plugin/src/service.rs Outdated
Comment thread crate/clients/k8s_plugin/src/service.rs Outdated
Comment thread crate/clients/k8s_plugin/src/config.rs
Comment thread crate/clients/k8s_plugin/src/main.rs Outdated
Comment thread documentation/docs/integrations/kubernetes_kms_plugin.md
Comment thread crate/clients/k8s_operator/src/main.rs
Comment thread crate/clients/k8s_operator/src/config.rs Outdated
Comment thread crate/clients/k8s_plugin/Cargo.toml Outdated
Comment thread crate/clients/k8s_operator/Cargo.toml Outdated
Comment thread crate/test_kms_server/src/vector_runner.rs
p0wline and others added 2 commits June 19, 2026 10:34
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
p0wline and others added 14 commits June 19, 2026 10:37
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ng deps to operator, fix machete false positives
# Conflicts:
#	.github/workflows/packaging.yml
#	.github/workflows/test_all.yml
#	Cargo.lock
#	nix/expected-hashes/cli.vendor.linux.sha256
#	test_data
Fixes WASM build failure on wasm32-unknown-unknown caused by
tracing-appender 0.2.5 depending on the symlink crate (not available
on wasm32). Resolves #1002.
p0wline added 2 commits June 23, 2026 15:37
Use cosmian_logger (already a workspace dependency) with features=["full"]
in the k8s plugin and operator, reading standard OpenTelemetry env vars:
- OTEL_EXPORTER_OTLP_ENDPOINT: enables OTLP export when set
- OTEL_SERVICE_NAME: service name reported to the collector (operator only)
- RUST_LOG / --log-level: log verbosity (plugin)

Avoids introducing a git dependency with a rust-version constraint
incompatible with the workspace toolchain (1.91.0 vs 1.94.1).

A cosmian_logger 0.7.3 release adding init_tracing() is tracked in
Cosmian/http_client_server#21.

Closes #1002
# Conflicts:
#	nix/expected-hashes/server.vendor.static.sha256
#	nix/expected-hashes/ui.vendor.non-fips.sha256

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 22 out of 23 changed files in this pull request and generated 21 comments.

Comment thread crate/clients/k8s_operator/Cargo.toml Outdated
Comment thread crate/clients/k8s_operator/src/controller.rs Outdated
Comment thread crate/clients/k8s_operator/src/controller.rs Outdated
Comment thread crate/clients/k8s_operator/src/controller.rs Outdated
Comment thread crate/clients/k8s_operator/src/controller.rs Outdated
Comment thread crate/clients/k8s_plugin/src/integration_tests.rs Outdated
Comment thread crate/clients/k8s_plugin/build.rs
Comment thread crate/clients/k8s_operator/src/webhook.rs
Comment thread documentation/docs/integrations/kubernetes_kms_plugin.md
Comment thread crate/clients/k8s_plugin/src/config.rs
p0wline and others added 3 commits June 23, 2026 16:46
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants