Le KMS français 🥖🇫🇷 - #1124
Open
HatemMn wants to merge 7 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds French (fr) as an additional UI locale in the React/Ant Design frontend by wiring French into the existing i18n locale registry and providing French translation bundles.
Changes:
- Register French locale support for Ant Design and Day.js locale switching.
- Add French translation resources for
common,menu,layout,locate, andactionsnamespaces. - Add a branch changelog entry describing the UI locale addition (with one wording issue noted in review comments).
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/src/i18n/useAppLocale.ts | Imports Day.js French locale so dayjs.locale("fr") works when French is selected. |
| ui/src/i18n/localeRegistry.ts | Registers the fr locale (label, AntD locale, Day.js locale, matcher, and translation bundles). |
| ui/src/i18n/locales/fr/menu.json | French translations for sidebar/menu entries. |
| ui/src/i18n/locales/fr/locate.json | French translations for the Locate page UI strings. |
| ui/src/i18n/locales/fr/layout.json | French translations for layout strings (header/footer/login/404/etc.). |
| ui/src/i18n/locales/fr/common.json | Shared/common French UI strings. |
| ui/src/i18n/locales/fr/actions.json | French translations for action forms and related UI copy. |
| CHANGELOG/feat_french_kms.md | Documents the feature in the branch changelog (one refactoring claim appears inaccurate). |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Contributor
Author
|
Will just check smth |
Manuthor
force-pushed
the
feat/kms_french
branch
from
August 22, 2026 05:32
57461c2 to
6728c2a
Compare
Manuthor
force-pushed
the
feat/kms_french
branch
3 times, most recently
from
August 23, 2026 08:30
7e21eee to
f3427e2
Compare
Manuthor
force-pushed
the
feat/kms_french
branch
from
August 24, 2026 06:18
f3427e2 to
e640c78
Compare
Manuthor
force-pushed
the
feat/kms_french
branch
from
August 24, 2026 06:36
204584f to
4fec1f3
Compare
- fix(crl): use find_all in find_revoked_certificates so CRL includes certs from all users, not just those accessible to the requesting user - feat(crl): add CO guard at generate_crl entry; audit-log CO bypass - feat(crl): add KMS::find_active_co() helper (first active CO or None) - feat(crl): auto-regenerate issuer CRL on certificate revocation when kms_public_url is set; uses find_active_co for signer identity; errors are warn-logged and never fail the Revoke operation - feat(db): add crls table (SQLite/PgSQL/MySQL/Redis) with upsert_crl and get_crl; table created at server boot alongside all other tables - feat(crl): persist signed CRL to DB after every generate_crl call - feat(crl): get_cached_crl loads from DB on cold start (no 404 after server restart); public CDP endpoint immediately available - test(crl): add test_crl_contains_certs_from_all_users — regression guard for find_all fix: 3 certs owned by 2 users, CRL must have 3 entries; reverts to 1 without fix - fix(lychee): exclude crate/ from link checks to avoid false-positive parse errors on multi-host PostgreSQL connection strings in comments - docs(pki): sync pki.md with auto-CDP injection, public CDP endpoint, CO requirement, auto-regen on revoke, DB persistence, kms_public_url - docs(revoke): remove stale 'revocation reason not maintained' sentence - docs(tables): add crls table (count 5->6, schema, ERD, Redis note) - docs(log-reference): add new auto-CRL warn/info/audit log entries
Manuthor
force-pushed
the
feat/kms_french
branch
from
August 24, 2026 06:37
4fec1f3 to
a874b49
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
translated to french
To reviewers
As you can see, diffs are way too minimal, which does proves that i18n was integrated very well
However as you might have guessed the translation being machine generated not much toughts were put into it, so please just go through reading random snippets (or navigate the UI) and comment if some terms seems too machinal (example: I didn't like "calculer le hashage" as we naturally say "calculer le hash")