Skip to content

Add rank model files for SNVs and SVs in deliverables#169

Open
diitaz93 wants to merge 9 commits into
mainfrom
add-rank-model-files
Open

Add rank model files for SNVs and SVs in deliverables#169
diitaz93 wants to merge 9 commits into
mainfrom
add-rank-model-files

Conversation

@diitaz93

@diitaz93 diitaz93 commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Description

Add support for rank-model files to be added to the case housekeeper bundles in cg

Added

  • New set of tags InputFileTags with "rank-model-snv" and "rank-model-sv"
  • Entries in the Tag dictionaries for Nallo and raredisease of SNV and SV rank model files

Changed

  • Updated docs

Fixed

  • Contributing page

Testing

How to prepare for test

  • ssh to Hasta
  • Test your branch with
hermes-test-deploy <branch-name>
hermes-test <command here>

How to test

  • login to ...
  • do ...

Expected test result

  • check that ...
  • Take a screenshot and attach or copy/paste the output.

Review

  • code approved by
  • tests executed by
  • "Merge and deploy" approved by
    Thanks for filling in who performed the code review and the test!

This version is a:

  • MAJOR - when you make incompatible API changes
  • MINOR - when you add functionality in a backwards compatible manner
  • PATCH - when you make backwards compatible bug fixes or documentation/instructions

@codecov-commenter

codecov-commenter commented Jul 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.91%. Comparing base (36adae0) to head (cd6cce6).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #169      +/-   ##
==========================================
+ Coverage   92.84%   92.91%   +0.06%     
==========================================
  Files          28       28              
  Lines        1020     1030      +10     
==========================================
+ Hits          947      957      +10     
  Misses         73       73              
Flag Coverage Δ
unittests 92.91% <100.00%> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@diitaz93
diitaz93 marked this pull request as ready for review July 20, 2026 10:09
@diitaz93
diitaz93 requested a review from a team as a code owner July 20, 2026 10:09

@peterpru peterpru left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add SNV and SV rank model files to HK bundle fro nallo and raredisease

3 participants