Skip to content
This repository was archived by the owner on Dec 27, 2019. It is now read-only.

Commit file delete made by phing.#1314

Open
jimafisk wants to merge 1 commit into
developfrom
remove-apple-icons
Open

Commit file delete made by phing.#1314
jimafisk wants to merge 1 commit into
developfrom
remove-apple-icons

Conversation

@jimafisk

Copy link
Copy Markdown
Contributor

Fixes N/A

Changes proposed in this pull request:

  • Every time I run the build script ./task.sh -Dbehat.run-server=true build:test the rsync behavior from scripts/make/non-destructive-make-core.sh deletes the following files:
    • docroot/apple-touch-icon-precomposed.png
    • docroot/apple-touch-icon.png
    • docroot/flush_cache.php

Just putting this into git history so we don't make devs decide what to do with the changes that scripts are making.

Add @mentions of the person or team responsible for reviewing proposed changes

@jimafisk jimafisk requested a review from davidrkupton March 26, 2019 19:21

@davidrkupton davidrkupton left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we stop Phing from deleting them?

@jimafisk

Copy link
Copy Markdown
Contributor Author

Yeah probably. So the flush_cache.php was something I did for the Hub/Ping cutover, that can go. If we need the icons then I think we should look into the rsync that's happening in scripts/make/non-destructive-make-core.sh. Would you rather do that than merge this removal? I assume the files are already gone on the remote Acquia environments given what's happening with the local builds.

@davidrkupton

Copy link
Copy Markdown
Contributor

Maybe we could adjust rsync-include.txt and rsync-exclude.txt to make sure they are not removed ...

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants