Migrate CLA Process - #13651
Conversation
|
Thank you for the pull request, @lukemckinstry! ✅ We can confirm we have a CLA on file for you. |
9f44b47 to
3d370f9
Compare
|
ready for review @ggetz |
ggetz
left a comment
There was a problem hiding this comment.
Thanks @lukemckinstry! The scripts all look good to me except with a few minor comments.
Before we move forward with this PR, I do want to check on the following workflow aspects:
- contributor documentation
- form submission without a Microsoft account
| const parseMicrosoftGraphInfo = () => { | ||
| const configJson = process.env.MICROSOFT_GRAPH_INFO_JSON; | ||
| if (!configJson) { | ||
| return {}; |
There was a problem hiding this comment.
Should this throw an error if the config cannot be found?
| "Rotate the Microsoft Graph credentials used by the CLA check workflow (`.github/workflows/cla.yml`).", | ||
| "", | ||
| "### Checklist", | ||
| "- [ ] Rotate Azure app client secret used by `MICROSOFT_GRAPH_INFO_JSON`", |
There was a problem hiding this comment.
Do we have contributor documentation on how one can update these values? If not, we probably should 🙂
It would also be helpful to link there from this issue for ease of discovery.
There was a problem hiding this comment.
added readme with docs
|
|
||
| - [individuals](https://docs.google.com/forms/d/e/1FAIpQLScU-yvQdcdjCFHkNXwdNeEXx5Qhu45QXuWX_uF5qiLGFSEwlA/viewform) and | ||
| - [corporations](https://docs.google.com/forms/d/e/1FAIpQLSeYEaWlBl1tQEiegfHMuqnH9VxyfgXGyIw13C2sN7Fj3J3GVA/viewform). | ||
| - [individuals](https://forms.cloud.microsoft/Pages/ResponsePage.aspx?id=MpZ-Bkzq2U6ebeKUlW4oSwLq-QNnfjxPgQhu1KdM4KxUQk43SlM5Q1NWQ1dGTVoyWjMzT1dCSk5GSy4u) and |
There was a problem hiding this comment.
This should be fixed now, the links should take you to the form without requiring sign in
Co-authored-by: Gabby Getz <gabby@cesium.com>

Description
Migrate CLA check process to MS Sharepoint.
Not ready to merge until I have added links to thenew CLA forms.Links to new CLA form added in this PR and ready to goImplementation notes
Due to security settings for the check CLA process (uses
on pull_request_target) this CI process will not run until its in main, so it is probably easiest to test this after merging the PR.When we merge the PR we need to copy the latest entries from the old CLA speadsheets to the new ones
Issue number and link
Testing plan
Set environment variables locally
MICROSOFT_GRAPH_INFO_JSONcopy full json blobPULL_REQUST_INFOsetGITHUB_ACTORat a minimum to test check against previous CLA signers. You can also set all vars to check positing message on corresponding GitHub PR, but that logic has not changed.run script locally
Author checklist
CONTRIBUTORS.md[] I have updatedCHANGES.mdwith a short summary of my change[] I have added or updated unit tests to ensure consistent code coverage[] I have updated the inline documentation, and included code examples where relevantAI acknowledgment
If yes, I used the following Tools(s) and/or Service(s):
VS Studio Code Copilot
If yes, I used the following Model(s):
ChatGPT-5.3-Codex