Skip to content

Migrate CLA Process - #13651

Open
lukemckinstry wants to merge 11 commits into
mainfrom
migrate-cla
Open

Migrate CLA Process#13651
lukemckinstry wants to merge 11 commits into
mainfrom
migrate-cla

Conversation

@lukemckinstry

@lukemckinstry lukemckinstry commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Description

Migrate CLA check process to MS Sharepoint.

Not ready to merge until I have added links to thenew CLA forms. Links to new CLA form added in this PR and ready to go

Implementation notes

  • Due to security settings for the check CLA process (uses on pull_request_target) this CI process will not run until its in main, so it is probably easiest to test this after merging the PR.

  • When we merge the PR we need to copy the latest entries from the old CLA speadsheets to the new ones

Issue number and link

Testing plan

  1. CLA Form
  • Sign CLA form (individual & corporate)
  • Check sharepoint to verify correct information was recorded
  1. Local testing steps for CI process

Set environment variables locally

  • MICROSOFT_GRAPH_INFO_JSON copy full json blob
  • PULL_REQUST_INFO set GITHUB_ACTOR at a minimum to test check against previous CLA signers. You can also set all vars to check positing message on corresponding GitHub PR, but that logic has not changed.

run script locally

cd .github/actions/check-for-CLA/
npm install
node index.js

Author checklist

  • I have submitted a Contributor License Agreement
  • I have added my name to CONTRIBUTORS.md
  • [] I have updated CHANGES.md with a short summary of my change
  • [] I have added or updated unit tests to ensure consistent code coverage
  • [] I have updated the inline documentation, and included code examples where relevant
  • I have performed a self-review of my code

AI acknowledgment

  • I used AI to generate content in this PR
  • If yes, I have reviewed the AI-generated content before submitting

If yes, I used the following Tools(s) and/or Service(s):

VS Studio Code Copilot

If yes, I used the following Model(s):

ChatGPT-5.3-Codex

@lukemckinstry lukemckinstry changed the title setup sharepoint lookup Migrate CLA Process Jul 27, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thank you for the pull request, @lukemckinstry!

✅ We can confirm we have a CLA on file for you.

@CesiumGS CesiumGS deleted a comment from github-actions Bot Jul 27, 2026
@lukemckinstry

Copy link
Copy Markdown
Contributor Author

ready for review @ggetz

@ggetz ggetz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lukemckinstry! The scripts all look good to me except with a few minor comments.

Before we move forward with this PR, I do want to check on the following workflow aspects:

  • contributor documentation
  • form submission without a Microsoft account

Comment thread .github/actions/check-for-CLA/index.js Outdated
const parseMicrosoftGraphInfo = () => {
const configJson = process.env.MICROSOFT_GRAPH_INFO_JSON;
if (!configJson) {
return {};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this throw an error if the config cannot be found?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added error

Comment thread .github/actions/check-for-CLA/index.js Outdated
"Rotate the Microsoft Graph credentials used by the CLA check workflow (`.github/workflows/cla.yml`).",
"",
"### Checklist",
"- [ ] Rotate Azure app client secret used by `MICROSOFT_GRAPH_INFO_JSON`",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have contributor documentation on how one can update these values? If not, we probably should 🙂

It would also be helpful to link there from this issue for ease of discovery.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added readme with docs

Comment thread CONTRIBUTING.md

- [individuals](https://docs.google.com/forms/d/e/1FAIpQLScU-yvQdcdjCFHkNXwdNeEXx5Qhu45QXuWX_uF5qiLGFSEwlA/viewform) and
- [corporations](https://docs.google.com/forms/d/e/1FAIpQLSeYEaWlBl1tQEiegfHMuqnH9VxyfgXGyIw13C2sN7Fj3J3GVA/viewform).
- [individuals](https://forms.cloud.microsoft/Pages/ResponsePage.aspx?id=MpZ-Bkzq2U6ebeKUlW4oSwLq-QNnfjxPgQhu1KdM4KxUQk43SlM5Q1NWQ1dGTVoyWjMzT1dCSk5GSy4u) and

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I open this link in incognito mode, I'm prompted for a sign in and can't proceed without one:

Image

I don't think we expect every contributor to have an existing Microsoft account.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be fixed now, the links should take you to the form without requiring sign in

@lukemckinstry
lukemckinstry requested a review from ggetz August 20, 2026 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants