Skip to content

Add support for 3DTILES_content_conditional in serializer / deserializer - #1351

Merged
j9liu merged 11 commits into
mainfrom
3d-tiles-content-conditional
May 6, 2026
Merged

Add support for 3DTILES_content_conditional in serializer / deserializer#1351
j9liu merged 11 commits into
mainfrom
3d-tiles-content-conditional

Conversation

@lilleyse

@lilleyse lilleyse commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Description

Adds support for 3DTILES_content_conditional in Cesium3DTiles, Cesium3DTilesReader, and Cesium3DTilesWriter. This is used by an internal pipeline generating time-dynamic 3D Tiles.

Note: this is still a draft extension, but should be safe to merge as not too many changes are expected.

Issue number or link

Author checklist

  • I have submitted a Contributor License Agreement (only needed once).
  • I have done a full self-review of my code.
  • I have updated CHANGES.md with a short summary of my change (for user-facing changes).
  • I have added or updated unit tests to ensure consistent code coverage as necessary.
  • I have updated the documentation as necessary.

Remaining Tasks

Testing plan

Reviewer checklist

Thank you for taking the time to review this PR. By approving a PR you are taking as much responsibility for these changes as the author.

As you review, please go through the checklist below:

  • Review and run all parts of the test plan on this branch and verify it matches expectations.
    • If the issue is a bug please make sure you can reproduce the bug in the main branch and then checkout this branch to make sure it actually solved the issue.
  • Review the code and make sure you do not have any remaining questions or concerns. You should understand the code change and the chosen approach. If you are not confident or have doubts about the code, please do not hesitate to ask questions.
  • Review the unit tests and make sure there are no missing tests or edge cases.
  • Review documentation changes and updates to CHANGES.md to make sure they accurately cover the work in this PR.
  • Verify that the Contributor License Agreement has been submitted, if needed.

@j9liu
j9liu self-requested a review May 1, 2026 21:26

@j9liu j9liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilleyse! Just a few minor comments to address before merge.

Comment thread tools/generate-classes/package.json
Comment thread Cesium3DTilesWriter/include/Cesium3DTilesWriter/ConditionalContentWriter.h Outdated
Comment thread Cesium3DTilesWriter/include/Cesium3DTilesWriter/ConditionalContentWriter.h Outdated
Comment thread Cesium3DTilesWriter/src/ConditionalContentWriter.cpp Outdated
@lilleyse

lilleyse commented May 6, 2026

Copy link
Copy Markdown
Contributor Author

@j9liu ready for another review!

@j9liu j9liu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lilleyse!

@j9liu
j9liu merged commit a6c06a2 into main May 6, 2026
28 checks passed
@j9liu
j9liu deleted the 3d-tiles-content-conditional branch May 6, 2026 19:15
@lilleyse
lilleyse restored the 3d-tiles-content-conditional branch August 18, 2026 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants