[Feature] 하단 내비게이션 바 컴포넌트 구현#8
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
📝 WalkthroughWalkthroughAdds a new ChangesNavigation bar feature
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/design-system/package.json (1)
26-28: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winBound the React peer range to the tested major.
>=19.0.0also claims React 20+ compatibility, which this PR does not establish. Prefer^19.0.0unless you already test future majors.Suggested change
"peerDependencies": { - "react": ">=19.0.0" + "react": "^19.0.0" },🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/design-system/package.json` around lines 26 - 28, The React peer dependency range in package.json is too broad because it claims compatibility with future major versions not yet tested. Update the peerDependencies entry for react from a lower-bounded range to the tested major range, using the package.json peerDependencies block as the target so it only accepts React 19.x unless future majors are explicitly validated.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/design-system/package.json`:
- Around line 26-28: The React peer dependency range in package.json is too
broad because it claims compatibility with future major versions not yet tested.
Update the peerDependencies entry for react from a lower-bounded range to the
tested major range, using the package.json peerDependencies block as the target
so it only accepts React 19.x unless future majors are explicitly validated.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: 7ee67916-8419-47e4-a926-0c2190b68173
⛔ Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (6)
apps/storybook/src/NavigationBar.stories.tsxpackages/design-system/package.jsonpackages/design-system/src/NavigationBar.css.tspackages/design-system/src/NavigationBar.tsxpackages/design-system/src/NavigationBarIcons.tsxpackages/design-system/src/index.ts
Summary
@comma/design-system의NavigationBar컴포넌트로 추가했습니다.rest,feed,archive,mypageactive 상태와 inline SVG 아이콘, glass pill 스타일을 구현했습니다.Scope
Validation
pnpm --filter @comma/design-system typecheckpnpm --filter @comma/storybook typecheckpnpm lintpnpm build:storybookNotes
pnpm lint는 기존apps/web/public/images/onboardingBackground*.svg대용량 파일 경고 2개를 출력하지만 실패하지 않습니다.Summary by CodeRabbit
New Features
Bug Fixes
Chores