fix: expand leading ~ in path flags and profiles#48
Merged
Conversation
Quoted "~/path" args reach the program literally since the shell only expands an unquoted ~. The literal ~ was then joined relative to cwd, producing paths like /home/user/~/... that fail to resolve. Closes #46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Quoted
"~/path"arguments reach the program literally since the shell only expands an unquoted~. The literal~was then joined relative to cwd, producing broken paths like/home/user/~/....Fix
internal/paths/expand.go- newExpandTilde(). Expands leading~/~/...to home dir. Leaves~user, mid-path~, and relative paths alone.cmd/root.go-expandFlagPaths()inPersistentPreRunEexpandsinstance-dir,log-file,cache-dir, and theupdate-allcache flag.internal/profile/profile.go-Load()expands storedinstance-dir/cache-dir/log-file(coversupdate-allper-profile paths).Tests
Written test-first (TDD). Cover the helper, profile load, and flag wiring. Full suite +
go vet+gofmtclean. Verified end-to-end:--instance-dir "~/inst"loads state from$HOME/inst.Closes #46