opensbi: optionally support fw_payload - #505
Open
heshamelmatary wants to merge 2 commits into
Open
Conversation
Current cheribuild only uses the fw_jump variant of OpenSBI while there exists other variants as well such as fw_payload that could be used. This commit enables choosing the payload variant of opensbi (which could embed u-boot and/or other OSes) and install it as an optional (QEMU's) firmware variant besides fw_jump.
heshamelmatary
force-pushed
the
opensbi_fw_payload
branch
from
June 17, 2026 14:20
b2e70c3 to
21bd08b
Compare
heshamelmatary
force-pushed
the
opensbi_fw_payload
branch
from
June 17, 2026 14:40
21bd08b to
f251973
Compare
arichardson
reviewed
Jun 18, 2026
arichardson
left a comment
arichardson
left a comment
Member
There was a problem hiding this comment.
Isn't this missing the logic to actually add a payload when building opensbi?
Member
Author
Yeah but that's a separate issue/PR here [1]. I just decoupled them because even without [1], it will still build a dummy payload and run it, even if the user mistakenly/explicitly uses this new QEMU flag without building a proper payload. [1] #504 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Current cheribuild only uses the fw_jump variant of OpenSBI while there exists other variants as well such as fw_payload that could be used. This commit enables choosing the payload variant of opensbi (which could embed u-boot and/or other OSes) and install it as an optional (QEMU's) firmware variant besides fw_jump.