-
Notifications
You must be signed in to change notification settings - Fork 58
docker image: switch to a new non-root user when started as root #241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
arichardson
wants to merge
5
commits into
master
Choose a base branch
from
docker-entrypoint
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e6724b0
docker: Use a single layer for all apt packages
arichardson debe56b
docker image: switch to a new non-root user when started as root
arichardson a691207
docker image: Use `useradd` instead of adduser
arichardson f3b6c4a
docker image: silence debug echo
arichardson 16c6e6a
docker image: Copy the cheribuild configuration to the home directory
arichardson File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,21 @@ | ||
| #!/bin/sh -e | ||
|
|
||
| if [ "$(id -u)" != 0 ]; then | ||
| # echo "Already running as non-root, can't change user." | ||
| exec "$@" | ||
| fi | ||
| # Create a non-root user with UID/GID matching the host user to ensure that | ||
| # files written to the volumes are not owned by root. | ||
| : "${cheribuild_uid:=1234}" | ||
| : "${cheribuild_gid:=1234}" | ||
| : "${cheribuild_user:=cheri}" | ||
| addgroup --quiet --gid ${cheribuild_gid} "${cheribuild_user}" | ||
| useradd --uid "${cheribuild_uid}" --gid "${cheribuild_gid}" --create-home --no-user-group --password '*' "${cheribuild_user}" | ||
|
|
||
| # Copy the cheribuild configuration to the unprivileged user's home directory: | ||
| export HOME="/home/${cheribuild_user}" | ||
| mkdir "${HOME}/.config" | ||
| cp -f /root/.config/cheribuild.json "${HOME}/.config/cheribuild.json" | ||
| chown -R "${cheribuild_uid}:${cheribuild_gid}" "${HOME}/.config" | ||
| # Run the actual command: | ||
| exec gosu "${cheribuild_user}" "$@" | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.