tests: add contents_first with min & max depth - #164
Open
danielparks wants to merge 1 commit into
Open
Conversation
danielparks
force-pushed
the
test_contents_first_min_max
branch
from
May 29, 2023 15:42
011b877 to
dfa44f0
Compare
This just adds `contents_first(true)` versions of the existing tests for min and max depth. Given that handling contents first can be a bit confusing, it seemed wise to test it more thoroughly. For symmetry, this switches the existing min and max depth tests to use `path()` instead of `sorted_paths()`. Because all of the test directories only have one entry, there should never be an issue with entries being returned in a different, but still correct, order.
danielparks
force-pushed
the
test_contents_first_min_max
branch
from
December 30, 2025 03:20
dfa44f0 to
3ba1cc0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This just adds
contents_first(true)versions of the existing tests for min and max depth. Given that handling contents first can be a bit confusing, it seemed wise to test it more thoroughly.For symmetry, this switches the existing min and max depth tests to use
path()instead ofsorted_paths(). Because all of the test directories only have one entry, there should never be an issue with entries being returned in a different, but still correct, order.This isn’t strictly necessary, but when I was working on #163 I was concerned that min and max depth might break with
contents_first. No worries if you’d prefer not to add these, or if you’d prefer to keepsorted_paths().