feat: add events to the trafficManagerBackend controller#312
Merged
Conversation
Co-authored-by: zhiying-lin <54013513+zhiying-lin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] add events to the trafficManagerBackend controller
Add events to the trafficManagerBackend controller
May 27, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
==========================================
+ Coverage 80.30% 80.48% +0.17%
==========================================
Files 29 29
Lines 4108 4161 +53
==========================================
+ Hits 3299 3349 +50
- Misses 643 647 +4
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8bb03a8 to
50a233b
Compare
ryanzhang-oss
approved these changes
May 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds event recording to the
trafficManagerBackendcontroller, following the same pattern used in thetrafficmanagerprofilecontroller. Events are now emitted for important state changes and operations:Added events for:
Implementation details:
backendEventReasonAccepted,backendEventReasonDeleted,backendEventReasonAzureAPIError)ControllerNameconstant for use in event recordingEventRecorderfield to the Reconciler structmain.gohandleDeletehandleUpdatevalidateTrafficManagerProfilevalidateAzureTrafficManagerProfilevalidateServiceImportAndCleanupEndpointsIfInvalidThese events will help users and operators understand the status and lifecycle of the trafficManagerBackend resources and troubleshoot issues when they occur.
Fixes #306.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
cdn.fwupd.org/usr/bin/fwupdmgr refresh(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.