test: add 121 tests, fix screenshot tool for all 8 skins - #8
Merged
Conversation
…or all 8 skins Add targeted tests for backend trait defaults (stroke_rect, draw_line, ellipsis, word-wrap, blit fallbacks, clip stack), 12 UI widgets (button, toggle, input, list, scroll, progress, card, tab, badge, avatar, divider, panel), platform services (date conversion edge cases, time formatting, uptime monotonicity, OSK), and oasis-app VFS population. Add --check/--bless visual regression flags to screenshot tests. Fix screenshot tool to respect skin features: skip dashboard chrome for terminal-only skins, use skin screen dimensions (800x600 for desktop), create WM demo windows for desktop skin, and populate terminal-only skins via their own layout objects. Regenerate screenshots for all 8 skins and update README to showcase them all. Test count: 1,635 -> 1,756 (+121) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Review Response Agent (Iteration 1)Status: No changes needed Fixed Issues
Ignored Issues
Deferred to Human
Notes
The agent reviewed feedback but determined no code changes were required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tests added
backend.rsplatform/tests.rsmain.rsscreenshot_tests.rsScreenshot tool fixes
skin.features.dashboard-- skip dashboard chrome for terminal-only skinsskin.manifest.screen_width/heightinstead of hardcoded 480x272 (fixes desktop skin at 800x600)Test plan
cargo test --workspace-- 1,756 passed, 0 failedcargo clippy --workspace -- -D warnings-- cleancargo fmt --all -- --check-- cleanGenerated with Claude Code