Skip to content

test: add 121 tests, fix screenshot tool for all 8 skins - #8

Merged
AndrewAltimit merged 1 commit into
mainfrom
test/coverage-weak-spots
Feb 12, 2026
Merged

test: add 121 tests, fix screenshot tool for all 8 skins#8
AndrewAltimit merged 1 commit into
mainfrom
test/coverage-weak-spots

Conversation

@AndrewAltimit

Copy link
Copy Markdown
Owner

Summary

  • Add 121 new tests across 5 weak coverage areas, bringing the total from 1,635 to 1,756
  • Fix screenshot tool to correctly render all 8 skins (was broken for terminal-only and desktop skins)
  • Regenerate screenshots for all 8 skins and update README to showcase them

Tests added

Area Tests Files
Backend trait defaults (stroke_rect, draw_line, ellipsis, word-wrap, blit, clip) ~18 backend.rs
UI widgets (button, toggle, input, list, scroll, progress, card, tab, badge, avatar, divider, panel) ~79 12 widget files
Platform services (date conversion, time formatting, uptime, OSK) ~15 platform/tests.rs
oasis-app VFS population 10 main.rs
Visual regression (--check/--bless flags) infra screenshot_tests.rs

Screenshot tool fixes

  • Respect skin.features.dashboard -- skip dashboard chrome for terminal-only skins
  • Use skin.manifest.screen_width/height instead of hardcoded 480x272 (fixes desktop skin at 800x600)
  • Create WM demo windows (Terminal + File Manager) for desktop skin
  • Populate terminal-only skins via their own layout objects instead of overlapping generic chrome
  • Agent-terminal no longer has overlapping dashboard/statusbar/bottombar

Test plan

  • cargo test --workspace -- 1,756 passed, 0 failed
  • cargo clippy --workspace -- -D warnings -- clean
  • cargo fmt --all -- --check -- clean
  • All 8 skins generate correct screenshots without crashes

Generated with Claude Code

…or all 8 skins

Add targeted tests for backend trait defaults (stroke_rect, draw_line,
ellipsis, word-wrap, blit fallbacks, clip stack), 12 UI widgets
(button, toggle, input, list, scroll, progress, card, tab, badge,
avatar, divider, panel), platform services (date conversion edge cases,
time formatting, uptime monotonicity, OSK), and oasis-app VFS
population. Add --check/--bless visual regression flags to screenshot
tests.

Fix screenshot tool to respect skin features: skip dashboard chrome for
terminal-only skins, use skin screen dimensions (800x600 for desktop),
create WM demo windows for desktop skin, and populate terminal-only
skins via their own layout objects. Regenerate screenshots for all 8
skins and update README to showcase them all.

Test count: 1,635 -> 1,756 (+121)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@AndrewAltimit

Copy link
Copy Markdown
Owner Author

Review Response Agent (Iteration 1)

Status: No changes needed

Fixed Issues

  • (none — no real bugs found)

Ignored Issues

  • Gemini review: failed with 503 UNAVAILABLE, no feedback produced
  • Codex review: output truncated, no actionable feedback extracted
  • FNV-1a hash collision risk in screenshot comparison: theoretical only, probability ~5.4×10^-20 per comparison, adequate for deterministic screenshot diffs
  • Missing terminal_prompt fallback in populate_skin_terminal: not a bug — all 4 terminal-only skins define this object in their layout definitions

Deferred to Human

  • (none)

Notes

  • Both external reviewers (Gemini and Codex) failed due to infrastructure issues, not code problems
  • Independent review of all 50 changed files found no bugs, incorrect assertions, or security issues
  • All existing tests pass (cargo test -p oasis-core -- days_to_ymd verified, 11/11 passed)

The agent reviewed feedback but determined no code changes were required.

@AndrewAltimit
AndrewAltimit merged commit cc67def into main Feb 12, 2026
7 checks passed
@AndrewAltimit
AndrewAltimit deleted the test/coverage-weak-spots branch February 12, 2026 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant