fix: disable QuickJS javascript feature in WASM backend - #37
Merged
Conversation
rquickjs-sys requires clang to cross-compile QuickJS C code for wasm32-unknown-unknown, which is not available in the GitHub Pages deploy environment. The javascript feature (oasis-js/QuickJS) remains enabled for the SDL desktop backend via oasis-app. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Codex AI Code ReviewIssues (if any)(none) Previous Issues (for incremental reviews)(none) Suggestions (if any)
Notes
Generated by Codex AI (gpt-5.3-codex). Supplementary to human reviews. |
Prevents accidental reintroduction of the `javascript` feature flag, which requires clang for cross-compiling QuickJS to wasm32. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Review Response Agent (Iteration 1)Status: No changes needed Fixed Issues
Ignored Issues
Deferred to Human
Notes
The agent reviewed feedback but determined no code changes were required. |
Gemini AI Code ReviewIssues (if any)(none) Previous Issues (for incremental reviews)(none) Suggestions (if any)(none) Notes
Generated by Gemini AI (gemini-3.1-pro-preview). Supplementary to human reviews. |
Codex AI Incremental ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) Previous Issues (for incremental reviews)(none) Suggestions (if any)(none) Notes
Generated by Codex AI (gpt-5.3-codex). Supplementary to human reviews. |
Owner
Author
Review Response Agent (Iteration 2)Status: No changes needed Fixed Issues
Ignored Issues
Deferred to Human
Notes
The agent reviewed feedback but determined no code changes were required. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
javascriptfeature was enabled foroasis-backend-wasm, pulling inrquickjs-syswhich requiresclangto cross-compile QuickJS C code forwasm32-unknown-unknownclangis not installedjavascriptfeature from the WASM backend'soasis-coredependency -- QuickJS remains enabled for the SDL desktop backend viaoasis-appRoot cause
PR #35 (JavaScript engine) added
features = ["javascript"]tooasis-backend-wasm/Cargo.toml. This was fine for native builds but broke the WASM build sincerquickjs-sysneeds a C cross-compiler (clang) that isn't available in the Pages deploy environment.Test plan
cargo check -p oasis-backend-wasmpasses without the featurecargo clippy --workspace -- -D warningscleancargo test --workspacepassesGenerated with Claude Code