refactor(browser): split css/values/apply.rs into apply/ submodule - #167
Conversation
The old apply.rs was 4412 lines and bundled four unrelated concerns:
the per-property dispatch match, the value-token parsers, the initial-
value reset / shorthand parsing, and a 950-line test module.
Split along those boundaries:
apply/mod.rs (2074) — apply_declaration dispatch
apply/parsers.rs (918) — free parsers (transform, clip-path, filter,
grid-template-areas, font families, ...)
apply/initial.rs (418) — apply_initial reset, transition/animation
shorthands, inline-logical resolution
apply/container.rs (118) — will-change + container shorthand
apply/tests.rs (960) — test cases
No file in the split exceeds 2500 lines. Pure mechanical move:
no behavior change, all 1954 browser unit tests + visual regression
goldens pass unchanged.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Openrouter AI General ReviewIssues (if any)(none) Previous Issues (for incremental reviews)(none) Suggestions (if any)
Notes
Generated by Openrouter AI (qwen/qwen3.6-plus). Supplementary to human reviews. |
Claude AI Architecture & Quality ReviewThe grep confirms the three Issues (if any)(none) Previous Issues (for incremental reviews)(none) Suggestions (if any)
Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Claude AI Incremental Security & Correctness ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) Previous Issues (for incremental reviews)
Suggestions (if any)
Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Automated fix by Claude in response to AI review feedback. Iteration: 1/5 Co-Authored-By: AI Review Agent <noreply@anthropic.com>
Review Response Agent (Iteration 1)Status: Changes committed, pushing... Commit: Fixed Issues
Ignored Issues
Deferred to Human
Notes
Automated summary of agent fixes. |
Openrouter AI Incremental General ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)
Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Openrouter AI (qwen/qwen3.6-plus). Supplementary to human reviews. |
Claude AI Incremental Security & Correctness ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Claude AI Incremental Architecture & Quality ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) Previous Issues (for incremental reviews)
Suggestions (if any)
Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Automated fix by Claude in response to AI review feedback. Iteration: 2/5 Co-Authored-By: AI Review Agent <noreply@anthropic.com>
Review Response Agent (Iteration 2)Status: Changes committed, pushing... Commit: Fixed Issues
Ignored Issues
Deferred to Human
Notes
Automated summary of agent fixes. |
Claude AI Incremental Security & Correctness ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)
Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Claude AI Incremental Architecture & Quality ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) — the only changes in commit Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Openrouter AI Incremental General ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)
Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Openrouter AI (qwen/qwen3.6-plus). Supplementary to human reviews. |
Automated fix by Claude in response to AI review feedback. Iteration: 3/5 Co-Authored-By: AI Review Agent <noreply@anthropic.com>
Review Response Agent (Iteration 3)Status: Changes committed, pushing... Commit: Fixed Issues
Ignored Issues
Deferred to Human
Notes
Automated summary of agent fixes. |
Openrouter AI Incremental General ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Openrouter AI (qwen/qwen3.6-plus). Supplementary to human reviews. |
Claude AI Incremental Security & Correctness ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Claude AI Incremental Architecture & Quality ReviewThis is an incremental review focusing on changes since the last review. Issues (if any)(none) Previous Issues (for incremental reviews)
Suggestions (if any)(none) Notes
Generated by Claude AI (sonnet). Supplementary to human reviews. |
Review Response Agent (Iteration 4)Status: Hallucination detected — no commit
Stream log: Fixed Issues
Ignored Issues
Deferred to Human
Notes
No file modifications were performed; this iteration produced no commit. |






Summary
crates/oasis-browser/src/css/values/apply.rshad grown to 4412 lines bundling four unrelated concerns. Split along those concern boundaries into a sibling-file submodule.No file in the split exceeds 2500 lines. Pure mechanical move; no behaviour change.
Test plan