Restrict scroll to just the modal body - #907
Open
aswallace wants to merge 4 commits into
Open
Conversation
aswallace
marked this pull request as ready for review
August 19, 2026 18:34
BrianWhitneyAI
approved these changes
Aug 19, 2026
| if (!el) return; | ||
|
|
||
| const checkScroll = () => { | ||
| const isOverflowing = el.scrollHeight > el.clientHeight; |
Contributor
There was a problem hiding this comment.
should this be like hasOverflowingContent or something.
…bugfix/modals-content-overlapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Resolves #815.
For the base modal class, the entire modal had scrolling applied because of FluentUI internal styling. A side effect of this was that the "body" content of the modal often overlapped with the header and/or footer.
Changes
Restricts scroll styling to just the body and applies a gradient to the bottom of the container when there's still scrollable content.
Testing
Manually tested each of our modal types
Screenshots
Before
After