[codex] refactor shared biased-linear kernel#199
Merged
AbdelStark merged 1 commit intoJun 10, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pwm_core::predictor::batched_linearas the shared sequence-row variant of the biased linear kernelprove_blockBatchedLinear through the shared helper instead of keeping a local row loopRoot Cause
Issue #182 tracks drift risk from multiple biased-linear implementations. The flat helper was already shared, but the batched block prover still carried its own row-wise expansion. This keeps the batched path behind the same core kernel boundary as the reference and flat prover paths.
Closes #182.
Validation
cargo test -p pwm-core linear_kernels_match_freivalds_relationcargo test -p pwm-verifier --test block accept_multiposition_attention_with_projectioncargo test --workspacecargo clippy --workspace --all-targets -- -D warnings