Skip to content

lpc4322_hic: make use of OS_CLOCK defined in yaml#924

Closed
groleo wants to merge 1 commit into
ARMmbed:developfrom
groleo:OS_CLOCK
Closed

lpc4322_hic: make use of OS_CLOCK defined in yaml#924
groleo wants to merge 1 commit into
ARMmbed:developfrom
groleo:OS_CLOCK

Conversation

@groleo

@groleo groleo commented Jan 6, 2022

Copy link
Copy Markdown

No description provided.

@mathias-arm mathias-arm requested a review from flit January 6, 2022 18:25
@mathias-arm

Copy link
Copy Markdown
Collaborator

I have also wondered if we should not replace SystemCoreClock with OS_CLOCK there too:

#define CPU_CLOCK SystemCoreClock ///< Specifies the CPU Clock in Hz

cc: @flit

@groleo

groleo commented Jan 6, 2022

Copy link
Copy Markdown
Author

I have also wondered if we should not replace SystemCoreClock with OS_CLOCK there too:

My guess is that when SystemCoreClock is used, its value is re-read it in case it was modified. (again, just a guess)

@mathias-arm

Copy link
Copy Markdown
Collaborator

My guess is that when SystemCoreClock is used, its value is re-read it in case it was modified. (again, just a guess)

That's my guess too, but ideally we should be able to decide a frequency. The difference between a variable and a constant might be important in this case, because this is used by CMSIS-DAP for timing SWD/JTAG bit-banging.

@groleo

groleo commented Jan 7, 2022

Copy link
Copy Markdown
Author

Moved to #925

@groleo groleo closed this Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants