Skip to content

Commit d545984

Browse files
Refactor SparkClient constructors (#1318)
add overloads that accept a zFactoryClassName string.
1 parent 67d34ec commit d545984

2 files changed

Lines changed: 19 additions & 5 deletions

File tree

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -31,3 +31,4 @@ assembly/dependency-reduced-pom.xml
3131

3232
# Sphinx _build
3333
**/_build
34+
/python/venv

spark/client/src/main/java/zingg/spark/client/SparkClient.java

Lines changed: 18 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -30,22 +30,35 @@ public class SparkClient extends Client<SparkSession, Dataset<Row>, Row, Column,
3030
private JavaSparkContext javaSparkContext;
3131

3232
public SparkClient(IZArgs args, ClientOptions options) throws ZinggClientException {
33-
super(args, options, zFactoryClassName);
34-
33+
this(args, options, zFactoryClassName);
3534
}
3635

3736

3837
public SparkClient(IZArgs args, ClientOptions options, SparkSession s) throws ZinggClientException {
39-
super(args, options, s, zFactoryClassName);
40-
Analytics.track(Metric.IS_PYTHON, "true", args.getCollectMetrics());
38+
this(args, options, s, zFactoryClassName);
4139
}
4240

4341

4442
public SparkClient() {
45-
super(zFactoryClassName);
43+
this(zFactoryClassName);
44+
}
45+
46+
public SparkClient(IZArgs args, ClientOptions options, String zFactoryClassName) throws ZinggClientException {
47+
super(args, options, zFactoryClassName);
48+
4649
}
4750

4851

52+
public SparkClient(IZArgs args, ClientOptions options, SparkSession s, String zFactoryClassName) throws ZinggClientException {
53+
super(args, options, s, zFactoryClassName);
54+
Analytics.track(Metric.IS_PYTHON, "true", args.getCollectMetrics());
55+
}
56+
57+
58+
public SparkClient(String zFactoryClassName) {
59+
super(zFactoryClassName);
60+
}
61+
4962
@Override
5063
public Client<SparkSession, Dataset<Row>, Row, Column, DataType> getClient(IZArgs args,
5164
ClientOptions options) throws ZinggClientException {

0 commit comments

Comments
 (0)