merge MidiClip::{empty,isEmpty}

Author: yohannd1

include/MidiClip.h

@@ -112,10 +112,7 @@ class LMMS_EXPORT MidiClip : public Clip
 		return m_instrumentTrack;
 	}
 
-	// TODO: does this need to be distinct from isEmpty()?
-	bool empty() const;
-
-	bool isEmpty() const override { return empty(); }
+	bool isEmpty() const override;
 
 	gui::ClipView * createView( gui::TrackView * _tv ) override;
 

src/gui/clips/MidiClipView.cpp

@@ -202,13 +202,13 @@ void MidiClipView::constructContextMenu( QMenu * _cm )
 					this, SLOT(openInPianoRoll()));
 
 	auto b = new QAction(embed::getIconPixmap("ghost_note"), tr("Set as ghost in piano-roll"), _cm);
-	if( m_clip->empty() ) { b->setEnabled( false ); }
+	if( m_clip->isEmpty() ) { b->setEnabled( false ); }
 	_cm->insertAction( _cm->actions()[1], b );
 	connect( b, SIGNAL(triggered(bool)),
 					this, SLOT(setGhostInPianoRoll()));
 
 	auto c = new QAction(embed::getIconPixmap("automation_ghost_note"), tr("Set as ghost in automation editor"), _cm);
-	if (m_clip->empty()) { c->setEnabled(false); }
+	if (m_clip->isEmpty()) { c->setEnabled(false); }
 	_cm->insertAction(_cm->actions()[2], c);
 	connect(c, &QAction::triggered, this, &MidiClipView::setGhostInAutomationEditor);
 

src/gui/editors/PianoRoll.cpp

@@ -5818,7 +5818,7 @@ void PianoRollWindow::exportMidiClip()
 void PianoRollWindow::importMidiClip()
 {
 	// Overwrite confirmation.
-	if (!m_editor->m_midiClip->empty() &&
+	if (!m_editor->m_midiClip->isEmpty() &&
 		QMessageBox::warning(
 			nullptr,
 			tr("Import clip."),

src/tracks/MidiClip.cpp

@@ -648,7 +648,7 @@ void MidiClip::updatePatternTrack()
 
 
 
-bool MidiClip::empty() const
+bool MidiClip::isEmpty() const
 {
 	for (const auto& note : m_notes)
 	{