chore: enforce configured clippy thresholds (#180)

Author: thewrz

Cargo.toml

@@ -7,6 +7,10 @@ license = "MIT"
 description = "Wayland-native Linux soundboard"
 repository = "https://github.com/thewrz/HonkHonk"
 
+[lints.clippy]
+cognitive_complexity = "warn"
+too_many_lines = "warn"
+
 [dependencies]
 iced = { version = "0.14", features = ["tokio", "tiny-skia", "canvas"] }
 # Pure-Rust StatusNotifierItem tray over zbus. Replaces tray-icon/muda/gtk so

src/app/mod.rs

@@ -360,6 +360,10 @@ Select 'HonkHonk Mic' as your input in Discord/OBS."
 }
 
 impl HonkHonk {
+    #[allow(
+        clippy::too_many_lines,
+        reason = "constructor lists every app state field explicitly to avoid hidden defaults during app split"
+    )]
     pub fn new(
         mut tray: TrayHandle,
         audio: AudioHandle,
@@ -593,6 +597,11 @@ impl HonkHonk {
             .collect()
     }
 
+    #[allow(
+        clippy::cognitive_complexity,
+        clippy::too_many_lines,
+        reason = "legacy Elm update dispatcher is being split under #142; keep message routing visible until then"
+    )]
     pub fn update(&mut self, message: Message) -> Task<Message> {
         match message {
             Message::ToggleVisibility => {
@@ -1435,6 +1444,10 @@ impl HonkHonk {
         Some(banner.into())
     }
 
+    #[allow(
+        clippy::too_many_lines,
+        reason = "legacy root layout preserves Iced widget-state ordering while the app split proceeds under #142"
+    )]
     fn view_main(&self) -> Element<'_, Message> {
         let t = self.config.theme;
         let header = self.view_header(t);
@@ -2033,6 +2046,10 @@ mod tests {
         assert_eq!(app.now_playing.display_progress(), 0.0);
     }
 
+    #[allow(
+        clippy::too_many_lines,
+        reason = "regression test spells out the same-sound re-press event timeline from #149"
+    )]
     #[test]
     fn re_pressing_same_sound_keeps_playhead_alive() {
         // Re-pressing the SAME tile while it is still playing must re-trigger the

src/app/panels.rs

@@ -18,6 +18,10 @@ impl HonkHonk {
         }
     }
 
+    #[allow(
+        clippy::cognitive_complexity,
+        reason = "keeps persisted animation toggle and in-flight flourish cleanup colocated"
+    )]
     pub(super) fn set_panel_animations(&mut self, enabled: bool) -> Task<Message> {
         if self.config.panel_animations != enabled {
             self.config = AppConfig {

src/app/playback.rs

@@ -78,6 +78,10 @@ impl HonkHonk {
     /// `Ok` caches the PCM and starts playback; an `Err` logs and tears down the
     /// optimistic state so it does not stick (#151). The `Decoded` arm in
     /// `update` delegates straight here.
+    #[allow(
+        clippy::cognitive_complexity,
+        reason = "decode landing owns stale-generation, cache, playback, and UI cleanup invariants"
+    )]
     pub(super) fn handle_decoded(
         &mut self,
         id: String,

src/audio/engine.rs

@@ -364,6 +364,10 @@ fn spawn_stream_watcher(
     Ok((stream_watcher, stream_rx))
 }
 
+#[allow(
+    clippy::too_many_lines,
+    reason = "PipeWire mainloop setup keeps Rc handles and guards alive for the engine lifetime"
+)]
 fn run_engine(
     cmd_rx: pipewire::channel::Receiver<AudioCommand>,
     evt_tx: mpsc::Sender<AudioEvent>,
@@ -648,6 +652,10 @@ struct PlayRequest {
     mode: PlayMode,
 }
 
+#[allow(
+    clippy::too_many_lines,
+    reason = "play request lifecycle keeps error, stream, voice, and event ordering invariants together"
+)]
 fn handle_play(ctx: &EngineCtx, req: PlayRequest) {
     let PlayRequest {
         voice_id,

src/audio/error.rs

@@ -205,6 +205,10 @@ mod effects_error_tests {
 mod engine_error_event_tests {
     use super::*;
 
+    #[allow(
+        clippy::too_many_lines,
+        reason = "display regression enumerates every public EngineErrorEvent variant"
+    )]
     #[test]
     fn engine_error_event_display_preserves_existing_log_text() {
         let cases = [

src/audio/registry.rs

@@ -28,6 +28,10 @@ struct RegistryState {
     source_ports: HashMap<u32, Vec<u32>>,
 }
 
+#[allow(
+    clippy::cognitive_complexity,
+    reason = "PipeWire mic link creation keeps node guards, duplicate suppression, and error logging together"
+)]
 fn try_create_mic_links(
     state: &mut RegistryState,
     core: &pipewire::core::Core,
@@ -69,6 +73,10 @@ fn try_create_mic_links(
     }
 }
 
+#[allow(
+    clippy::cognitive_complexity,
+    reason = "PipeWire monitor link creation keeps node guards, duplicate suppression, and error logging together"
+)]
 fn try_create_monitor_links(
     state: &mut RegistryState,
     core: &pipewire::core::Core,
@@ -168,6 +176,11 @@ enum DeviceChange {
     Inputs,
 }
 
+#[allow(
+    clippy::cognitive_complexity,
+    clippy::too_many_lines,
+    reason = "registry callback keeps PipeWire object classification and device-change reporting together"
+)]
 fn handle_registry_global(
     global: &pipewire::registry::GlobalObject<&pipewire::spa::utils::dict::DictRef>,
     state: &mut RegistryState,
@@ -337,6 +350,10 @@ pub struct RegistryConfig {
     pub shared_sink_ports: Rc<RefCell<Vec<u32>>>,
 }
 
+#[allow(
+    clippy::too_many_lines,
+    reason = "PipeWire listener owns captured Rc guard setup that must stay in one lifetime scope"
+)]
 pub fn setup_registry_listener(
     core: &pipewire::core::CoreRc,
     cfg: RegistryConfig,

src/main.rs

@@ -8,6 +8,11 @@ fn effective_renderer(env_val: Option<&str>, config_pref: Renderer) -> Renderer
     }
 }
 
+#[allow(
+    clippy::cognitive_complexity,
+    clippy::too_many_lines,
+    reason = "startup sequence keeps renderer env setup before subsystem initialization"
+)]
 fn main() -> iced::Result {
     honkhonk::logging::init();
 

src/shortcuts/config_ui.rs

@@ -68,6 +68,10 @@ impl ShortcutConfigService {
             || matches!(self.desktop_env, DesktopEnv::Kde | DesktopEnv::Gnome)
     }
 
+    #[allow(
+        clippy::cognitive_complexity,
+        reason = "portal-first shortcut configuration keeps desktop fallback behavior in one ladder"
+    )]
     pub(crate) fn open(&self) {
         if self.portal_v2_available {
             if let Some(tx) = &self.portal_cmd_tx {

src/shortcuts/portal.rs

@@ -50,6 +50,10 @@ fn make_request_path(conn: &zbus::Connection, suffix: &str) -> zbus::Result<Owne
 /// setter, and Session constructors are also pub(crate). We call CreateSession
 /// directly via raw zbus to inject SESSION_TOKEN, then return the session path
 /// for use in subsequent bind/configure calls.
+#[allow(
+    clippy::too_many_lines,
+    reason = "raw zbus portal request keeps subscription, method call, and response parsing ordered"
+)]
 async fn create_session_fixed_token(
     conn: &zbus::Connection,
 ) -> Result<OwnedObjectPath, ashpd::Error> {
@@ -203,6 +207,10 @@ async fn configure_shortcuts_raw(
 /// `ShortcutEvent::Ready` once the portal session is established, then
 /// `ShortcutEvent::Activated(idx)` on each trigger press.
 /// Yields `ShortcutEvent::Failed(reason)` once on error, then ends.
+#[allow(
+    clippy::too_many_lines,
+    reason = "portal stream owns command channel setup plus activation/change select loop"
+)]
 pub fn shortcut_stream(_window_id: Option<WindowIdentifier>) -> impl Stream<Item = ShortcutEvent> {
     iced::stream::channel(32, async move |mut tx| {
         use ashpd::desktop::global_shortcuts::GlobalShortcuts;