Skip to content

Commit fa283f7

Browse files
authored
chore(ci): pin linuxdeploy/appimagetool to immutable release tags (#122)
The AppImage workflow downloaded both tools from upstream 'continuous' tags while pinning their SHA256s. Continuous assets get re-published and silently change checksum, so the pin rotted and broke the 0.1.0 release (linuxdeploy checksum mismatch). Pin to immutable versioned releases (linuxdeploy 1-alpha-20251107-1, appimagetool 1.9.1) with digests computed from those assets — URL and hash can no longer drift apart.
1 parent 73c7c08 commit fa283f7

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

.github/workflows/appimage.yml

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -12,10 +12,15 @@ permissions:
1212

1313
env:
1414
CARGO_TERM_COLOR: always
15-
# Pinned digests — update intentionally when upgrading these tools.
15+
# Pinned tool releases + digests — update both together when upgrading.
16+
# The old pins pointed at the upstream `continuous` tags, whose assets are
17+
# re-published and silently change checksum (broke the 0.1.0 release).
18+
# Immutable version tags keep download URL and digest in agreement.
1619
# Recompute: sha256sum <downloaded-file>
17-
LINUXDEPLOY_SHA256: eb1cf4c2ef45ac66fde05fb82b1adbbb0096a5cb741f1123ca644ce800f816ff
18-
APPIMAGETOOL_SHA256: a6d71e2b6cd66f8e8d16c37ad164658985e0cf5fcaa950c90a482890cb9d13e0
20+
LINUXDEPLOY_VERSION: 1-alpha-20251107-1
21+
LINUXDEPLOY_SHA256: c20cd71e3a4e3b80c3483cef793cda3f4e990aca14014d23c544ca3ce1270b4d
22+
APPIMAGETOOL_VERSION: 1.9.1
23+
APPIMAGETOOL_SHA256: ed4ce84f0d9caff66f50bcca6ff6f35aae54ce8135408b3fa33abfc3cb384eb0
1924

2025
jobs:
2126
build-appimage:
@@ -55,7 +60,7 @@ jobs:
5560
- name: Download and verify linuxdeploy
5661
run: |
5762
curl -fsSL -o linuxdeploy \
58-
https://github.com/linuxdeploy/linuxdeploy/releases/download/continuous/linuxdeploy-x86_64.AppImage
63+
"https://github.com/linuxdeploy/linuxdeploy/releases/download/${LINUXDEPLOY_VERSION}/linuxdeploy-x86_64.AppImage"
5964
echo "${LINUXDEPLOY_SHA256} linuxdeploy" | sha256sum --check --strict
6065
chmod +x linuxdeploy
6166
@@ -70,7 +75,7 @@ jobs:
7075
- name: Download and verify appimagetool
7176
run: |
7277
curl -fsSL -o appimagetool \
73-
https://github.com/AppImage/appimagetool/releases/download/continuous/appimagetool-x86_64.AppImage
78+
"https://github.com/AppImage/appimagetool/releases/download/${APPIMAGETOOL_VERSION}/appimagetool-x86_64.AppImage"
7479
echo "${APPIMAGETOOL_SHA256} appimagetool" | sha256sum --check --strict
7580
chmod +x appimagetool
7681

0 commit comments

Comments
 (0)