Hot Fix: Open AppStore directly rather than through SKStoreProductViewController (#23276)

Author: Paul Von Schrottky

RELEASE-NOTES.txt

@@ -1,6 +1,9 @@
 25.0
 -----
 
+24.9.1
+-----
+* [**] Fix bug where the option to switch to the Jetpack app is broken [#23276]
 
 24.9
 -----

WordPress/Classes/ViewRelated/Jetpack/Branding/Coordinator/JetpackRedirector.swift

@@ -1,5 +1,4 @@
 import Foundation
-import StoreKit
 
 class JetpackRedirector {
 
@@ -31,63 +30,11 @@ class JetpackRedirector {
 
         // First, check if the WordPress app can open Jetpack by testing its URL scheme.
         // if we can potentially open Jetpack app, let's open it through universal link to avoid scheme conflicts (e.g., a certain game :-).
-        // finally, if the user might not have Jetpack installed, open App Store view controller through StoreKit.
+        // finally, if the user might not have Jetpack installed, open App Store
         if UIApplication.shared.canOpenURL(jetpackDeepLinkURL) {
             UIApplication.shared.open(jetpackUniversalLinkURL)
         } else {
-            showJetpackAppInstallation(fallbackURL: jetpackAppStoreURL)
+            UIApplication.shared.open(jetpackAppStoreURL)
         }
     }
-
-    private static func showJetpackAppInstallation(fallbackURL: URL) {
-        let viewController = RootViewCoordinator.sharedPresenter.rootViewController.topmostPresentedViewController
-        let storeProductVC = SKStoreProductViewController()
-        let appID = [SKStoreProductParameterITunesItemIdentifier: "1565481562"]
-
-        configureNavigationBarAppearance(storeProductVC)
-
-        storeProductVC.loadProduct(withParameters: appID) { (result, error) in
-            if result {
-                viewController.present(storeProductVC, animated: true)
-            } else if let error = error {
-                DDLogError("Failed loading Jetpack App product: \(error.localizedDescription)")
-                UIApplication.shared.open(fallbackURL)
-            }
-        }
-    }
-
-    // MARK: - SKStoreProductViewController navigation bar appearance
-
-    /// Sets SKStoreProductViewController navigation bar translucent
-    ///
-    /// Application's global navigation appearance settings interferes with SKStoreProductViewController
-    /// which requires for this temporary workaround
-    private static func configureNavigationBarAppearance(_ controller: SKStoreProductViewController) {
-        let previousisTranslucentValue = UINavigationBar.appearance().isTranslucent
-        UINavigationBar.appearance().isTranslucent = true
-
-        /// Reset to default translucent value
-        storeProductViewControllerObserver = StoreProductViewControllerObserver(onDismiss: {
-            UINavigationBar.appearance().isTranslucent = previousisTranslucentValue
-            storeProductViewControllerObserver = nil
-        })
-
-        controller.delegate = storeProductViewControllerObserver
-    }
-
-    /// Observe product view controller dismissal
-    class StoreProductViewControllerObserver: NSObject, SKStoreProductViewControllerDelegate {
-        private let onDismiss: () -> ()
-
-        init(onDismiss: @escaping () -> ()) {
-            self.onDismiss = onDismiss
-            super.init()
-        }
-
-        func productViewControllerDidFinish(_ viewController: SKStoreProductViewController) {
-            onDismiss()
-        }
-    }
-
-    private static var storeProductViewControllerObserver: StoreProductViewControllerObserver?
 }