Enable SwiftLint rule: toggle_bool (#25504)

Prefer `someBool.toggle()` over `someBool = !someBool`. 12 violations
auto-fixed; no manual changes required.

Part of the Orchard SwiftLint rollout campaign.

Author: mokagio

.swiftlint.yml

@@ -62,6 +62,9 @@ only_rules:
 
   - shorthand_optional_binding
 
+  # Prefer `someBool.toggle()` over `someBool = !someBool`.
+  - toggle_bool
+
   # Files should have a single trailing newline.
   - trailing_newline
 

Sources/WordPressAuthenticator/Helpers/UnifiedAuth/ViewRelated/ReusableViews/TextFieldTableViewCell.swift

@@ -173,7 +173,7 @@ private extension TextFieldTableViewCell {
     }
 
     @objc func secureTextEntryToggleAction(_ sender: Any) {
-        textField.isSecureTextEntry = !textField.isSecureTextEntry
+        textField.isSecureTextEntry.toggle()
 
         // Save and re-apply the current selection range to save the cursor position
         let currentTextRange = textField.selectedTextRange

WordPress/Classes/ViewRelated/Blog/Sharing/SharingButtonsViewController.swift

@@ -406,7 +406,7 @@ class SharingButtonsViewController: UITableViewController {
                 switchCell.onChange = { [weak self] newValue in
                     guard let self else { return }
                     WPAnalytics.track(.sharingButtonsEditSharingButtonsToggled, properties: ["checked": newValue as Any], blog: self.blog)
-                    self.buttonsSection.editing = !self.buttonsSection.editing
+                    self.buttonsSection.editing.toggle()
                     self.updateButtonOrderAfterEditing()
                     self.reloadButtons()
                 }
@@ -452,7 +452,7 @@ class SharingButtonsViewController: UITableViewController {
                     guard let self else { return }
                     WPAnalytics.track(.sharingButtonsEditMoreButtonToggled, properties: ["checked": newValue as Any], blog: self.blog)
                     self.updateButtonOrderAfterEditing()
-                    self.moreSection.editing = !self.moreSection.editing
+                    self.moreSection.editing.toggle()
                     self.reloadButtons()
                 }
             }

WordPress/Classes/ViewRelated/Cells/ExpandableCell.swift

@@ -53,7 +53,7 @@ class ExpandableCell: WPReusableTableViewCell, NibLoadable {
     }
 
     public func toggle() {
-        expanded = !expanded
+        expanded.toggle()
     }
 
     private func setupSubviews() {

WordPress/Classes/ViewRelated/Notifications/Controllers/NotificationSettingsViewController.swift

@@ -582,10 +582,10 @@ extension NotificationSettingsViewController {
         let section = self.section(at: index.section)
         switch section {
         case .blog:
-            displayBlogMoreWasAccepted = !displayBlogMoreWasAccepted
+            displayBlogMoreWasAccepted.toggle()
 
         case .followedSites:
-            displayFollowedMoreWasAccepted = !displayFollowedMoreWasAccepted
+            displayFollowedMoreWasAccepted.toggle()
 
         default:
             return

WordPress/Classes/ViewRelated/Notifications/Views/NoteBlockUserTableViewCell.swift

@@ -96,7 +96,7 @@ class NoteBlockUserTableViewCell: NoteBlockTableViewCell {
             if let listener = isFollowOn ? onUnfollowClick : onFollowClick {
                 listener()
             }
-            isFollowOn = !isFollowOn
+            isFollowOn.toggle()
         }
     }
 

WordPress/Classes/ViewRelated/Plugins/ViewModels/PluginViewModel.swift

@@ -383,7 +383,7 @@ class PluginViewModel: Observable {
             expandedText: setHTMLTextAttributes(text),
             expanded: descriptionExpandedStatus,
             action: { [unowned self] row in
-                self.descriptionExpandedStatus = !self.descriptionExpandedStatus
+                self.descriptionExpandedStatus.toggle()
                 (row as? ExpandableRow)?.expanded = self.descriptionExpandedStatus
             },
             onLinkTap: { [unowned self] url in
@@ -399,7 +399,7 @@ class PluginViewModel: Observable {
             expandedText: setHTMLTextAttributes(text),
             expanded: installationExpandedStatus,
             action: { [unowned self] row in
-                self.installationExpandedStatus = !self.installationExpandedStatus
+                self.installationExpandedStatus.toggle()
                 (row as? ExpandableRow)?.expanded = self.installationExpandedStatus
             },
             onLinkTap: { [unowned self] url in
@@ -415,7 +415,7 @@ class PluginViewModel: Observable {
             expandedText: setHTMLTextAttributes(text),
             expanded: changeLogExpandedStatus,
             action: { [unowned self] row in
-                self.changeLogExpandedStatus = !self.changeLogExpandedStatus
+                self.changeLogExpandedStatus.toggle()
                 (row as? ExpandableRow)?.expanded = self.changeLogExpandedStatus
             },
             onLinkTap: { [unowned self] url in
@@ -431,7 +431,7 @@ class PluginViewModel: Observable {
             expandedText: setHTMLTextAttributes(text),
             expanded: faqExpandedStatus,
             action: { [unowned self] row in
-                self.faqExpandedStatus = !self.faqExpandedStatus
+                self.faqExpandedStatus.toggle()
                 (row as? ExpandableRow)?.expanded = self.faqExpandedStatus
             },
             onLinkTap: { [unowned self] url in

WordPress/Classes/ViewRelated/Reader/Cards/Tags View/ReaderTopicCollectionViewCoordinator.swift

@@ -206,7 +206,7 @@ extension ReaderTopicCollectionViewCoordinator: UICollectionViewDelegateFlowLayo
             return
         }
 
-        layout.isExpanded = !layout.isExpanded
+        layout.isExpanded.toggle()
         layout.invalidateLayout()
 
         WPAnalytics.trackReader(.readerChipsMoreToggled)