Merge branch 'develop' of https://github.com/wintercms/winter into develop

Author: LukeTowers

modules/backend/formwidgets/datepicker/partials/_picker_date.php

@@ -1,11 +1,16 @@
 <!-- Date -->
+<?php /* The field's <label for> targets the hidden data-locker input, leaving this
+        visible text box without an accessible name (WCAG 1.3.1 / 4.1.2). Name it directly. */ ?>
 <div class="input-with-icon right-align">
-    <i class="icon icon-calendar-o"></i>
+    <i class="icon icon-calendar-o" aria-hidden="true"></i>
     <input
         type="text"
         id="<?= $this->getId('date') ?>"
         class="form-control align-right"
         autocomplete="off"
+        <?php if ($field->label): ?>
+            aria-label="<?= e(trans($field->label)) ?>"
+        <?php endif ?>
         <?= $field->getAttributes() ?>
         data-datepicker />
 </div>

modules/backend/formwidgets/datepicker/partials/_picker_time.php

@@ -1,11 +1,17 @@
 <!-- Time -->
+<?php /* Same as _picker_date.php — the field's <label for> targets the hidden data-locker
+        input, leaving this visible text box without an accessible name (WCAG 1.3.1 / 4.1.2).
+        "(time)" distinguishes it from the date box in datetime mode, where both share the label. */ ?>
 <div class="input-with-icon right-align">
-    <i class="icon icon-clock-o"></i>
+    <i class="icon icon-clock-o" aria-hidden="true"></i>
     <input
         type="text"
         id="<?= $this->getId('time') ?>"
         class="form-control align-right"
         autocomplete="off"
+        <?php if ($field->label): ?>
+            aria-label="<?= e(trans($field->label)) ?> (time)"
+        <?php endif ?>
         <?= $field->getAttributes() ?>
         data-timepicker />
 </div>

modules/backend/formwidgets/fileupload/partials/_file_single.php

@@ -16,8 +16,10 @@ class="field-fileupload style-file-single <?= $singleFile ? 'is-populated' : ''
 >
 
     <!-- Upload Button -->
+    <?php /* Core renders an icon-only button with no accessible name (WCAG 4.1.2). */ ?>
     <button type="button" class="btn btn-default upload-button">
-        <i class="<?= e($iconClass) ?>"></i>
+        <i class="<?= e($iconClass) ?>" aria-hidden="true"></i>
+        <span class="sr-only"><?= e(trans('backend::lang.fileupload.upload_file')) ?></span>
     </button>
 
     <!-- Existing file -->