Merge pull request #250 from voxpupuli/modulesync

modulesync 10.6.0

Author: bastelfreak

.devcontainer/devcontainer.json

@@ -1,4 +1,3 @@
-// For format details, see https://aka.ms/devcontainer.json. For config options, see the
 {
 	"name": "VoxBox",
 	"image": "ghcr.io/voxpupuli/voxbox:latest"

.github/workflows/create_tag.yml

@@ -0,0 +1,22 @@
+---
+# Managed by modulesync - DO NOT EDIT
+# https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
+
+name: Create Git tag
+
+on:
+  workflow_dispatch:
+
+permissions: {}
+
+jobs:
+  create_tag:
+    uses: 'voxpupuli/gha-puppet/.github/workflows/create_tag.yml@v4'
+    with:
+      allowed_owner: 'voxpupuli'
+      git_name: 'pccibot'
+      git_email: '12855858+pccibot@users.noreply.github.com'
+    secrets:
+      # Configure secrets here:
+      #  https://docs.github.com/en/actions/security-guides/encrypted-secrets
+      ssh_private_key: ${{ secrets.PCCI_SSH_PRIVATE_KEY }}

.github/workflows/prepare_release.yml

@@ -17,11 +17,14 @@ permissions:
 
 jobs:
   release_prep:
-    uses: 'voxpupuli/gha-puppet/.github/workflows/prepare_release.yml@v3'
+    uses: 'voxpupuli/gha-puppet/.github/workflows/prepare_release.yml@v4'
     with:
       version: ${{ github.event.inputs.version }}
       allowed_owner: 'voxpupuli'
+      git_name: 'pccibot'
+      git_email: '12855858+pccibot@users.noreply.github.com'
     secrets:
       # Configure secrets here:
       #  https://docs.github.com/en/actions/security-guides/encrypted-secrets
       github_pat: '${{ secrets.PCCI_PAT_RELEASE_PREP }}'
+      ssh_private_key: '${{ secrets.PCCI_SSH_PRIVATE_KEY }}'

.github/workflows/release.yml

@@ -8,15 +8,17 @@ name: Release
 on:
   push:
     tags:
-      - '*'
+      # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#onpushbranchestagsbranches-ignoretags-ignore
+      # https://docs.github.com/en/actions/reference/workflows-and-actions/workflow-syntax#filter-pattern-cheat-sheet
+      - 'v[0-9]+.[0-9]+.[0-9]+'
 
 permissions:
   contents: write
 
 jobs:
   release:
     name: Release
-    uses: voxpupuli/gha-puppet/.github/workflows/release.yml@v3
+    uses: voxpupuli/gha-puppet/.github/workflows/release.yml@v4
     with:
       allowed_owner: 'voxpupuli'
     secrets:

.msync.yml

@@ -2,4 +2,4 @@
 # Managed by modulesync - DO NOT EDIT
 # https://voxpupuli.org/docs/updating-files-managed-with-modulesync/
 
-modulesync_config_version: '10.5.0'
+modulesync_config_version: '10.7.0'

.rubocop_todo.yml

@@ -1,13 +1,22 @@
 # This configuration was generated by
-# `rubocop --auto-gen-config`
-# on 2023-08-17 21:37:00 UTC using RuboCop version 1.50.2.
+# `rubocop --auto-gen-config --no-auto-gen-timestamp`
+# using RuboCop version 1.85.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 1
+# Offense count: 4
+RSpec/LeakyLocalVariable:
+  Exclude:
+    - 'spec/classes/proxysql_spec.rb'
+    - 'spec/type_aliases/galerahostgroup_spec.rb'
+
+# Offense count: 4
 # This cop supports unsafe autocorrection (--autocorrect-all).
-Style/MapToHash:
+Style/MapIntoArray:
   Exclude:
-    - 'lib/puppet/provider/proxy_mysql_galera_hostgroup/proxysql.rb'
+    - 'lib/puppet/provider/proxy_cluster/proxysql.rb'
+    - 'lib/puppet/provider/proxy_mysql_server/proxysql.rb'
+    - 'lib/puppet/provider/proxy_mysql_server_no_hostgroup/proxysql.rb'
+    - 'lib/puppet/provider/proxy_mysql_user/proxysql.rb'

Gemfile

@@ -4,7 +4,7 @@
 source ENV['GEM_SOURCE'] || 'https://rubygems.org'
 
 group :test do
-  gem 'voxpupuli-test', '~> 13.0',  :require => false
+  gem 'voxpupuli-test', '~> 14.0',  :require => false
   gem 'puppet_metadata', '~> 6.0',  :require => false
 end
 
@@ -18,7 +18,7 @@ group :system_tests do
 end
 
 group :release do
-  gem 'voxpupuli-release', '~> 5.0',  :require => false
+  gem 'voxpupuli-release', '~> 5.3',  :require => false
 end
 
 gem 'rake', :require => false

lib/facter/proxysql_runtime.rb

@@ -33,7 +33,7 @@
       'runtime_mysql_query_rules',
       'runtime_mysql_query_rules_fast_routing',
       'runtime_mysql_replication_hostgroups',
-      'runtime_proxysql_servers'
+      'runtime_proxysql_servers',
     ].each do |table|
       results = client.query("SELECT * FROM #{table}")
       fact[table] = results.map { |row| row }

lib/puppet/provider/proxy_cluster/proxysql.rb

@@ -15,7 +15,7 @@ def self.instances
     instances = []
     if mysql_running
       servers = mysql([defaults_file, '-NBe',
-                       'SELECT `hostname`, `port` FROM `proxysql_servers`'].compact).split(%r{\n})
+                       'SELECT `hostname`, `port` FROM `proxysql_servers`',].compact).split(%r{\n})
 
       # To reduce the number of calls to MySQL we collect all the properties in
       # one big swoop.
@@ -34,7 +34,7 @@ def self.instances
           hostname: @hostname,
           port: @port,
           weight: @weight,
-          comment: @comment
+          comment: @comment,
         )
       end
     end
@@ -82,7 +82,7 @@ def exists?
   end
 
   def initialize(value = {})
-    super(value)
+    super
     @property_flush = {}
   end
 

lib/puppet/provider/proxy_mysql_galera_hostgroup/proxysql.rb

@@ -6,7 +6,7 @@
   commands mysql: 'mysql'
 
   def initialize(value = {})
-    super(value)
+    super
     @property_flush = {}
   end