Skip to content

Commit e0c6aac

Browse files
authored
Remove build-type from matrix (#1660)
Do not compile every single matrix build element in Release and Debug. Just target one element to compile in Debug, and compile in Release mode every other.
1 parent 6d55fda commit e0c6aac

1 file changed

Lines changed: 25 additions & 5 deletions

File tree

.github/workflows/mediasoup-worker.yaml

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@ jobs:
2222
- os: ubuntu-22.04
2323
cc: gcc
2424
cxx: g++
25+
build-type: Release
2526
run-lint: false
2627
run-test: true
2728
run-test-asan-address: false
@@ -30,6 +31,7 @@ jobs:
3031
- os: ubuntu-22.04
3132
cc: clang
3233
cxx: clang++
34+
build-type: Release
3335
run-lint: false
3436
run-test: true
3537
run-test-asan-address: false
@@ -38,6 +40,7 @@ jobs:
3840
- os: ubuntu-22.04-arm
3941
cc: gcc
4042
cxx: g++
43+
build-type: Release
4144
# No clang-format for ARM.
4245
run-lint: false
4346
run-test: true
@@ -47,17 +50,31 @@ jobs:
4750
- os: ubuntu-24.04
4851
cc: gcc
4952
cxx: g++
53+
build-type: Release
5054
pip-break-system-packages: true
5155
run-lint: false
5256
run-test: true
5357
run-test-asan-address: false
5458
run-test-asan-undefined: false
5559
run-test-asan-thread: false
56-
# Let's just compile with all Meson option flags enabled once with gcc.
60+
# Compile with all Meson option flags enabled once with gcc in Release mode.
61+
meson_args: '-Dms_log_trace=true -Dms_log_file_line=true -Dms_rtc_logger_rtp=true -Dms_disable_liburing=true -Dms_sctp_stack=true'
62+
- os: ubuntu-24.04
63+
cc: gcc
64+
cxx: g++
65+
build-type: Debug
66+
pip-break-system-packages: true
67+
run-lint: false
68+
run-test: true
69+
run-test-asan-address: false
70+
run-test-asan-undefined: false
71+
run-test-asan-thread: false
72+
# Compile with all Meson option flags enabled once with gcc in Debug mode.
5773
meson_args: '-Dms_log_trace=true -Dms_log_file_line=true -Dms_rtc_logger_rtp=true -Dms_disable_liburing=true -Dms_sctp_stack=true'
5874
- os: ubuntu-24.04
5975
cc: clang
6076
cxx: clang++
77+
build-type: Release
6178
pip-break-system-packages: true
6279
run-lint: false
6380
run-test: true
@@ -69,6 +86,7 @@ jobs:
6986
- os: ubuntu-24.04-arm
7087
cc: gcc
7188
cxx: g++
89+
build-type: Release
7290
pip-break-system-packages: true
7391
# No clang-format for ARM.
7492
run-lint: false
@@ -79,6 +97,7 @@ jobs:
7997
- os: ubuntu-24.04-arm
8098
cc: clang
8199
cxx: clang++
100+
build-type: Release
82101
pip-break-system-packages: true
83102
# No clang-format for ARM.
84103
run-lint: false
@@ -89,6 +108,7 @@ jobs:
89108
- os: macos-14
90109
cc: clang
91110
cxx: clang++
111+
build-type: Release
92112
pip-break-system-packages: true
93113
run-lint: false
94114
run-test: true
@@ -98,6 +118,7 @@ jobs:
98118
- os: macos-15
99119
cc: clang
100120
cxx: clang++
121+
build-type: Release
101122
pip-break-system-packages: true
102123
# Run lint for the latest macos.
103124
run-lint: true
@@ -108,6 +129,7 @@ jobs:
108129
- os: windows-2022
109130
cc: cl
110131
cxx: cl
132+
build-type: Release
111133
# No clang-format for Windows.
112134
run-lint: false
113135
# Maybe some day we fix this.
@@ -119,6 +141,7 @@ jobs:
119141
- os: windows-2025
120142
cc: cl
121143
cxx: cl
144+
build-type: Release
122145
# No clang-format for Windows.
123146
run-lint: false
124147
# Maybe some day we fix this.
@@ -130,9 +153,6 @@ jobs:
130153
# A single Node.js version should be fine for C++.
131154
node:
132155
- 24
133-
build-type:
134-
- Release
135-
- Debug
136156

137157
runs-on: ${{ matrix.build.os }}
138158

@@ -141,7 +161,7 @@ jobs:
141161
CXX: ${{ matrix.build.cxx }}
142162
MEDIASOUP_SKIP_WORKER_PREBUILT_DOWNLOAD: 'true'
143163
MEDIASOUP_LOCAL_DEV: 'false'
144-
MEDIASOUP_BUILDTYPE: ${{ matrix.build-type }}
164+
MEDIASOUP_BUILDTYPE: ${{ matrix.build.build-type }}
145165
MESON_ARGS: ${{ matrix.build.meson_args }}
146166

147167
steps:

0 commit comments

Comments
 (0)