Remove the dependency on Foundation (Dependencies still require it) (#417)

* Update aws-lambda and use the new plugin -- disable code strip for now

* `NIOFoundationCompat` -> `NIOFoundationEssentialsCompat`

* Make Penny itself Foundation-free

* Remove some CI installations

* Better verifier

* Refinements

Author: MahdiBM

.github/workflows/deploy-all-lambdas.yml

@@ -19,10 +19,12 @@ jobs:
       AWS_DEFAULT_REGION: eu-west-1
 
     steps:
-      - name: Install AWSCLI v2, jq, zstd, zip, binutils
+      - name: Install AWSCLI v2, jq, zstd, zip, and stub docker for the lambda-build plugin
         run: |
           dnf update -y
-          dnf install jq awscli zstd zip unzip binutils -y
+          dnf install jq awscli zstd zip -y
+          printf '#!/bin/sh\nexit 127\n' > /usr/local/bin/docker
+          chmod +x /usr/local/bin/docker
 
       - name: Check out repository
         uses: actions/checkout@v7
@@ -56,29 +58,11 @@ jobs:
           for name in ${{ steps.find_package_names.outputs.names }}; do
             swift package \
               --allow-network-connections docker \
-              archive \
+              lambda-build \
               --verbose \
-              --base-docker-image swift:6.3-amazonlinux2023 \
               --output-path ./zips \
+              --no-strip \
               --products "${name}"
-
-            # The archive plugin does not strip, and Lambda hard-caps deployment
-            # packages at 250 MB unzipped. Drop DWARF but keep the symbol table.
-            zip_path="$(pwd)/zips/${name}/${name}.zip"
-            unpacked="$(mktemp -d)"
-            unzip -q "${zip_path}" -d "${unpacked}"
-            strip --strip-debug "${unpacked}/bootstrap"
-
-            unzipped_bytes="$(du -sb "${unpacked}" | cut -f1)"
-            echo "${name}: $((unzipped_bytes / 1048576)) MiB unzipped after stripping"
-            if [ "${unzipped_bytes}" -ge 262144000 ]; then
-              echo "::error::${name} is ${unzipped_bytes} bytes unzipped, over Lambda's 262144000 limit"
-              exit 1
-            fi
-
-            rm "${zip_path}"
-            (cd "${unpacked}" && zip -qry "${zip_path}" .)
-            rm -rf "${unpacked}"
           done
 
       - name: Configure AWS credentials

Lambdas/AutoFaqs/S3AutoFaqsRepository.swift

@@ -1,5 +1,5 @@
 import Models
-import NIOFoundationCompat
+import NIOFoundationEssentialsCompat
 import SotoS3
 
 package import class SotoCore.AWSClient

Lambdas/AutoPings/S3AutoPingsRepository.swift

@@ -1,5 +1,5 @@
 package import Models
-import NIOFoundationCompat
+import NIOFoundationEssentialsCompat
 import SotoS3
 
 package import class SotoCore.AWSClient

Lambdas/Faqs/S3FaqsRepository.swift

@@ -1,5 +1,5 @@
 import Models
-import NIOFoundationCompat
+import NIOFoundationEssentialsCompat
 import SotoS3
 
 package import class SotoCore.AWSClient

Lambdas/GHHooks/EventHandler/Handlers/ReleaseMaker.swift

@@ -1,12 +1,10 @@
 import AsyncHTTPClient
 import DiscordBM
-/// Import full foundation even on linux for `trimmingCharacters`, for now.
-import Foundation
 import GitHubAPI
 import Logging
 import Markdown
 import NIOCore
-import NIOFoundationCompat
+import NIOFoundationEssentialsCompat
 import Shared
 import SwiftSemver
 
@@ -251,7 +249,7 @@ struct ReleaseMaker {
             )
         ).ok.body.json
         if (current.body ?? "")
-            .trimmingCharacters(in: .whitespacesAndNewlines)
+            .trimmingWhitespacesAndNewlines()
             .hasPrefix(Configuration.releaseNoticePrefix)
         {
             logger.debug(
@@ -452,15 +450,15 @@ struct ReleaseMaker {
 
 extension String {
     func trimmingReleaseNoticeFromBody() -> String {
-        let trimmedBody = self.trimmingCharacters(in: .whitespacesAndNewlines)
+        let trimmedBody = self.trimmingWhitespacesAndNewlines()
         if trimmedBody.hasPrefix(ReleaseMaker.Configuration.releaseNoticePrefix) {
             return trimmedBody.split(
                 separator: "\n",
                 omittingEmptySubsequences: false
             )
             .dropFirst()
             .joined(separator: "\n")
-            .trimmingCharacters(in: .whitespacesAndNewlines)
+            .trimmingWhitespacesAndNewlines()
         } else {
             return trimmedBody
         }

Lambdas/GHHooks/Extensions/+PR.swift

@@ -1,6 +1,5 @@
-/// Import full foundation even on linux for `folding(options:locale:)`, for now.
-import Foundation
 import GitHubAPI
+import Shared
 
 extension PullRequest {
 
@@ -73,14 +72,7 @@ extension String {
     fileprivate var hasDoNotMergePrefix: Bool {
         let folded = self.lowercased()
             .filter { !$0.isPunctuation }
-            .folding(
-                options: .caseInsensitive,
-                locale: nil
-            )
-            .folding(
-                options: .diacriticInsensitive,
-                locale: nil
-            )
+            .foldingDiacritics()
         return folded.hasPrefix("dnm") || folded.hasPrefix("do not merge")
     }
 }

Lambdas/GHHooks/Extensions/String+Document.swift

@@ -1,5 +1,3 @@
-/// Import full foundation even on linux for `trimmingCharacters`, for now.
-import Foundation
 import Markdown
 import Shared
 
@@ -119,9 +117,8 @@ extension String {
     }
 
     private func trimmingForMarkdown() -> String {
-        self.trimmingCharacters(
-            in: .whitespacesAndNewlines
-        ).trimmingWorthlessLines()
+        self.trimmingWhitespacesAndNewlines()
+            .trimmingWorthlessLines()
     }
 
     private func trimmingWorthlessLines() -> String {

Lambdas/GHOAuth/OAuthLambda.swift

@@ -7,7 +7,7 @@ import JWTKit
 import LambdasShared
 import Logging
 import Models
-import NIOFoundationCompat
+import NIOFoundationEssentialsCompat
 import Shared
 import SotoCore