Commit 7240652
Make: Build JavaScript Windows x64 prebuilds (#774)
The `build_javascript` job exported `CC=gcc`/`CXX=g++` for every OS. On
Windows `node-gyp` ignores both and builds with MSVC, but NumKong's ISA
probe reads the compiler from `$CC` while still emitting MSVC flag
syntax, so it shells out to `gcc /c /arch:AVX2 ... /nologo`. Every probe
fails, the failures are swallowed, and `nk_probes.h` lands with all 39
`NK_TARGET_*` set to zero.
The addon still builds and passes the test suite -- dynamic dispatch just
has no kernels to choose from -- so the result is a scalar-only binary
shipped to every Windows npm user. Scope the variables to the Linux step
and let the probe fall back to `cl.exe`, which enables Haswell and
Skylake.
Co-authored-by: Evgeniy Peshkov <2716874+GraDea@users.noreply.github.com>
Co-authored-by: Ash Vardanian <1983160+ashvardanian@users.noreply.github.com>1 parent 9c0ed29 commit 7240652
1 file changed
Lines changed: 12 additions & 13 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
813 | 813 | | |
814 | 814 | | |
815 | 815 | | |
816 | | - | |
817 | | - | |
818 | | - | |
819 | | - | |
820 | | - | |
821 | | - | |
822 | | - | |
823 | | - | |
824 | | - | |
| 816 | + | |
| 817 | + | |
825 | 818 | | |
826 | | - | |
827 | | - | |
828 | | - | |
829 | 819 | | |
830 | 820 | | |
831 | 821 | | |
| |||
852 | 842 | | |
853 | 843 | | |
854 | 844 | | |
855 | | - | |
| 845 | + | |
| 846 | + | |
| 847 | + | |
| 848 | + | |
| 849 | + | |
| 850 | + | |
| 851 | + | |
| 852 | + | |
| 853 | + | |
| 854 | + | |
856 | 855 | | |
857 | 856 | | |
858 | 857 | | |
| |||
0 commit comments