unslothai
diff --git a/‎studio/backend/core/inference/stt_ggml_sidecar.py‎
Lines changed: 6 additions & 1 deletion b/‎studio/backend/core/inference/stt_ggml_sidecar.py‎
Lines changed: 6 additions & 1 deletion
diff --git a/‎studio/setup.ps1‎
Lines changed: 45 additions & 10 deletions b/‎studio/setup.ps1‎
Lines changed: 45 additions & 10 deletions
diff --git a/‎tests/studio/install/test_setup_denied_install_tree.py‎
Lines changed: 113 additions & 4 deletions b/‎tests/studio/install/test_setup_denied_install_tree.py‎
Lines changed: 113 additions & 4 deletions
@@ -172,7 +172,12 @@ def _is_runnable(p: Path) -> bool:
     """A real whisper-server is an executable file. On Windows os.access(X_OK) is
     effectively an existence check; on Unix it rejects a non-executable stub so a
     half-written or wrong-mode file isn't mistaken for the server."""
-    return p.is_file() and (sys.platform == "win32" or os.access(p, os.X_OK))
+    try:
+        return p.is_file() and (sys.platform == "win32" or os.access(p, os.X_OK))
+    except OSError:
+        # is_file() propagates EACCES: an unreadable install dir must read as
+        # engine-unavailable, like a missing one, never a 500 out of stt/status.
+        return False
 
 
 def _whisper_install_marker(binary: str) -> Optional[dict]:
 
@@ -2940,6 +2940,14 @@ function Get-StudioAdoptableState {
         }
     }
     if ($denied) { return "Denied" }
+    # Windows reports a MISSING child of an unreadable directory as absent, so the
+    # probes above cannot tell "no markers here" from "cannot look"; listing the
+    # directory itself can. Without this a denied tree reads as unowned.
+    try { $null = @(Get-ChildItem -LiteralPath $Path -Force -ErrorAction Stop | Select-Object -First 1) }
+    catch {
+        if (Test-AccessDeniedError $_) { return "Denied" }
+        # Anything else was not adoptable before either; this must not throw.
+    }
     return "No"
 }
 # Boolean view for callers that only gate a cosmetic cleanup on adoption.
@@ -2950,7 +2958,10 @@ function Test-StudioOwnedAdoptable {
 function Assert-StudioOwnedOrAbsent {
     param(
         [Parameter(Mandatory = $true)][string]$Path,
-        [Parameter(Mandatory = $true)][string]$Label
+        [Parameter(Mandatory = $true)][string]$Label,
+        # whisper.cpp is non-fatal by contract, so it needs the denial handed back
+        # rather than exited on. Only this mode returns a value.
+        [switch]$NonFatal
     )
     # Denied is not Absent: a root we cannot read cannot be proven ours, and
     # returning here would let the caller replace it. Both stops stay gated on
@@ -2959,17 +2970,20 @@ function Assert-StudioOwnedOrAbsent {
     $pathState = Get-PathState -Path $Path -PathType Container
     if ($pathState -ne "Present") {
         if ($StudioHomeIsCustom -and $pathState -eq "Denied") {
+            if ($NonFatal) { return "Denied" }
             Exit-PathAccessDenied -Path $Path -Label $Label -OwnershipUnverified
         }
         return
     }
     $markerState = Get-PathState -Path (Join-Path $Path $StudioOwnedMarker) -PathType Leaf
     if ($StudioHomeIsCustom -and $markerState -eq "Denied") {
+        if ($NonFatal) { return "Denied" }
         Exit-PathAccessDenied -Path $Path -Label $Label -OwnershipUnverified
     }
     if ($StudioHomeIsCustom -and $markerState -ne "Present") {
         $adoptState = Get-StudioAdoptableState -Path $Path
         if ($adoptState -eq "Denied") {
+            if ($NonFatal) { return "Denied" }
             Exit-PathAccessDenied -Path $Path -Label $Label -OwnershipUnverified
         }
         if ($adoptState -eq "Yes") {
@@ -4333,6 +4347,12 @@ if ($env:WHISPER_SERVER_PATH -or $env:UNSLOTH_WHISPER_CPP_PATH) {
     substep "whisper.cpp: using a user-configured binary/dir; skipping managed install"
 } elseif ($env:UNSLOTH_SKIP_WHISPER_INSTALL -eq "1") {
     substep "whisper.cpp: install skipped (UNSLOTH_SKIP_WHISPER_INSTALL=1)"
+} elseif ($StudioHomeIsCustom -and (Test-Path -LiteralPath $WhisperInstaller) -and
+        (Assert-StudioOwnedOrAbsent -Path $WhisperCppDir -Label "whisper.cpp install" -NonFatal) -eq "Denied") {
+    # Never fatal, per the phase header: the guard below would exit the whole run
+    # on an unreadable tree, taking llama.cpp down with it. Only the denial is
+    # caught here; an unowned tree still stops.
+    step "whisper.cpp" "install directory cannot be read: access is denied; curated whisper.cpp dictation is unavailable; restore access to $WhisperCppDir or move it aside, then re-run setup; browser and Transformers dictation remain available" "Yellow"
 } elseif (Test-Path -LiteralPath $WhisperInstaller) {
     # The installer's atomic activation replaces the whole directory, so the
     # custom-home ownership guard must run first (mirrors the llama block).
@@ -4372,7 +4392,7 @@ if ($env:WHISPER_SERVER_PATH -or $env:UNSLOTH_WHISPER_CPP_PATH) {
         } else {
             step "whisper.cpp" "prebuilt installed"
         }
-        if ($StudioHomeIsCustom -and (Test-Path -LiteralPath $WhisperCppDir -PathType Container)) {
+        if ($StudioHomeIsCustom -and (Test-PathQuiet $WhisperCppDir "Container")) {
             Mark-StudioOwned -Path $WhisperCppDir
         }
     } elseif ($whisperExit -eq 3) {
@@ -4466,10 +4486,25 @@ $HasGitForBuild = $null -ne (Get-Command git -ErrorAction SilentlyContinue)
 # Check if existing llama-server matches current GPU mode. A CUDA-built binary
 # on a now-CPU-only machine (or vice versa) needs to be rebuilt.
 $NeedRebuild = $false
-if (Test-Path -LiteralPath $LlamaServerBin) {
+# A forced compile, a pinned PR or a custom source skips the prebuilt path and its
+# phase 3.4 denial guard, so this can be the first probe to read inside the tree.
+# A linked local dir is skipped: it reads through the junction into the user's own
+# checkout, and nothing here is consumed on that path anyway.
+$llamaBinState = if ($LocalLlamaCppLinked) { "Absent" } else { Get-PathState -Path $LlamaServerBin -PathType Leaf }
+if ($llamaBinState -eq "Denied") {
+    # Nothing proved this tree is ours here, so do not advise deleting it.
+    Exit-PathAccessDenied -Path $LlamaCppDir -Label "llama.cpp install" -OwnershipUnverified:$StudioHomeIsCustom
+}
+if ($llamaBinState -eq "Present") {
     $CmakeCacheFile = Join-Path $BuildDir "CMakeCache.txt"
-    if (Test-Path -LiteralPath $CmakeCacheFile) {
-        $cachedCuda = Select-String -LiteralPath $CmakeCacheFile -Pattern 'GGML_CUDA:BOOL=ON' -Quiet
+    if (Test-PathQuiet $CmakeCacheFile "Leaf") {
+        # A listed file can still deny the read, which Test-PathQuiet cannot see.
+        try {
+            $cachedCuda = Select-String -LiteralPath $CmakeCacheFile -Pattern 'GGML_CUDA:BOOL=ON' -Quiet
+        } catch {
+            if (-not (Test-AccessDeniedError $_)) { throw }
+            Exit-PathAccessDenied -Path $LlamaCppDir -Label "llama.cpp install" -OwnershipUnverified:$StudioHomeIsCustom
+        }
         if ($HasNvidiaSmi -and -not $cachedCuda) {
             Write-Host "   Existing llama-server is CPU-only but GPU is available -- rebuilding" -ForegroundColor Yellow
             $NeedRebuild = $true
@@ -4485,7 +4520,7 @@ if (Test-Path -LiteralPath $LlamaServerBin) {
 # build runs only when needed and no usable binary is already present. A linked
 # local dir sets $NeedLlamaSourceBuild = $false, so this no-ops for that path.
 $WillBuildLlamaFromSource = $NeedLlamaSourceBuild -and `
-    -not ((Test-Path -LiteralPath $LlamaServerBin) -and -not $NeedRebuild -and $RequestedLlamaTag -ne "master")
+    -not ((Test-PathQuiet $LlamaServerBin "Leaf") -and -not $NeedRebuild -and $RequestedLlamaTag -ne "master")
 if ($WillBuildLlamaFromSource) {
     if (-not $HasGitForBuild) {
         # Phase 1 keeps git optional, so only the automatic fallback after a failed prebuilt
@@ -4519,7 +4554,7 @@ if ($LocalLlamaCppLinked) {
 } elseif (-not $NeedLlamaSourceBuild) {
     Write-Host ""
     step "llama.cpp" "prebuilt (validated)"
-} elseif ((Test-Path -LiteralPath $LlamaServerBin) -and -not $NeedRebuild -and $RequestedLlamaTag -ne "master") {
+} elseif ((Test-PathQuiet $LlamaServerBin "Leaf") -and -not $NeedRebuild -and $RequestedLlamaTag -ne "master") {
     # Skip rebuild only for pinned tags (e.g. b8635).  When the requested
     # tag is "master" (a moving target), always rebuild so the binary picks
     # up new model architecture support (e.g. Gemma 4).
@@ -5063,16 +5098,16 @@ if ($LocalLlamaCppLinked) {
     $totalSec = [math]::Round($totalSw.Elapsed.TotalSeconds % 60, 1)
 
     # -- Summary --
-    if ($BuildOk -and (Test-Path -LiteralPath $LlamaServerBin)) {
+    if ($BuildOk -and (Test-PathQuiet $LlamaServerBin "Leaf")) {
         step "llama.cpp" "built"
         $QuantizeBin = Join-Path $BuildDir "bin\Release\llama-quantize.exe"
-        if (Test-Path -LiteralPath $QuantizeBin) {
+        if (Test-PathQuiet $QuantizeBin "Leaf") {
             step "llama-quantize" "built"
         }
         step "build time" "${totalMin}m ${totalSec}s" "DarkGray"
     } else {
         $altBin = Join-Path $BuildDir "bin\llama-server.exe"
-        if ($BuildOk -and (Test-Path -LiteralPath $altBin)) {
+        if ($BuildOk -and (Test-PathQuiet $altBin "Leaf")) {
             step "llama.cpp" "built"
             step "build time" "${totalMin}m ${totalSec}s" "DarkGray"
         } else {
 
@@ -102,19 +102,23 @@ def test_ownership_guard_distinguishes_denied_from_unowned():
     # unreadable; it must stay for the genuinely-unowned case only.
     assert "is not marked as an Unsloth-owned $Label" in guard
     # Both stops stay gated, so default-home installs behave exactly as before.
-    assert guard.count("$StudioHomeIsCustom -and") == 3
+    assert guard.count("$StudioHomeIsCustom -and") >= 3
 
 
 def test_no_bare_test_path_probes_inside_the_llama_install_tree():
     """Probes that read *inside* a tree whose permissions we do not control are
     the ones that throw; they must all go through the guarded helpers."""
     inside_tree = re.compile(
-        r"Test-Path\b[^\n]*(\$existingMetaPath|\$llamaMarker|\$_cand|Join-Path \$LlamaCppDir)"
+        r"Test-Path\b[^\n]*("
+        r"\$existingMetaPath|\$llamaMarker|\$_cand|Join-Path \$LlamaCppDir"
+        r"|\$LlamaServerBin|\$CmakeCacheFile|\$QuantizeBin|\$altBin"
+        r"|Join-Path \$BuildDir)"
     )
+    # A comment naming a probe is not a probe.
     offenders = [
         f"{index}: {line.strip()}"
         for index, line in enumerate(SETUP_PS1.splitlines(), start = 1)
-        if inside_tree.search(line)
+        if inside_tree.search(line.split("#", 1)[0])
     ]
     assert not offenders, offenders
 
@@ -232,7 +236,7 @@ def test_the_ownership_guard_never_advises_deleting_an_unverified_tree():
     the tree is ours. It already says "move it aside" when it can prove it."""
     guard = SETUP_PS1.split("function Assert-StudioOwnedOrAbsent", 1)[1].split("\nfunction ", 1)[0]
     calls = [line.strip() for line in guard.splitlines() if "Exit-PathAccessDenied" in line]
-    assert len(calls) == 3, calls
+    assert len(calls) >= 3, calls
     for line in calls:
         assert "-OwnershipUnverified" in line, line
     body = SETUP_PS1.split("function Exit-PathAccessDenied", 1)[1].split("\nfunction ", 1)[0]
@@ -265,3 +269,108 @@ def test_the_temp_dir_swap_checks_both_of_its_destructive_steps():
     # And catch a move that silently did not happen.
     assert '(Get-PathState -Path $LlamaCppDir) -ne "Absent"' in swap.split(move, 1)[1], swap
     assert "Test-Path -LiteralPath $OriginalLlamaCppDir" not in swap, swap
+
+
+def test_the_source_build_phase_probes_the_tree_three_state():
+    """A forced compile, a pinned PR or a custom source skips the prebuilt phase
+    and its denial guard, so the rebuild check is the first read inside the tree."""
+    build = _slice("$llamaBinState = ", "# -- Summary --")
+    assert "Get-PathState -Path $LlamaServerBin -PathType Leaf" in build, build
+    assert '$llamaBinState -eq "Denied"' in build, build
+    assert '$llamaBinState -eq "Present"' in build, build
+    assert "Test-Path -LiteralPath $LlamaServerBin" not in build, build
+
+
+def test_the_source_build_probe_skips_a_linked_local_dir():
+    """$LlamaCppDir is a junction onto the user's checkout there, so probing it
+    reads their tree, and nothing this block computes is consumed on that path."""
+    flat = " ".join(SETUP_PS1.split())
+    assert '$llamaBinState = if ($LocalLlamaCppLinked) { "Absent" }' in flat
+
+
+def test_the_source_build_denial_never_advises_deleting_an_unproven_tree():
+    """Nothing on this route ran the ownership guard, so under a custom home the
+    tree cannot be proven ours and the delete advice must stay suppressed."""
+    block = _slice("$llamaBinState = ", "$WillBuildLlamaFromSource")
+    denials = [ln.strip() for ln in block.splitlines() if "Exit-PathAccessDenied" in ln]
+    assert len(denials) >= 2, denials
+    assert all(d.endswith("-OwnershipUnverified:$StudioHomeIsCustom") for d in denials), denials
+    assert all(d.startswith("Exit-PathAccessDenied -Path $LlamaCppDir ") for d in denials), denials
+
+
+def test_the_cmake_cache_read_is_guarded_not_just_its_probe():
+    """Test-PathQuiet only proves the entry is listed; a deny ACE on the file
+    itself leaves the probe true and throws on the read below it."""
+    block = _slice("$CmakeCacheFile = Join-Path", "$WillBuildLlamaFromSource")
+    read = "Select-String -LiteralPath $CmakeCacheFile"
+    assert read in block, block
+    before, after = block.split(read, 1)
+    assert "try {" in before, before
+    assert "Test-AccessDeniedError" in after, after
+    assert "Exit-PathAccessDenied" in after, after
+
+
+def _slice(start: str, end: str) -> str:
+    """Both bounds asserted: an unasserted terminator does not fail, it silently
+    widens the window to end-of-file and makes everything inside it near-vacuous."""
+    assert start in SETUP_PS1, start
+    assert end in SETUP_PS1, end
+    return SETUP_PS1.split(start, 1)[1].split(end, 1)[0]
+
+
+def _whisper_phase() -> str:
+    """The whisper phase body. Both anchors are asserted so a phase renumbering
+    fails as an assertion instead of an IndexError, and cannot silently widen
+    the window to end-of-file."""
+    return _slice("Install the whisper.cpp prebuilt", "PHASE 3.5")
+
+
+def test_the_whisper_phase_survives_an_unreadable_whisper_tree():
+    """The phase header promises failure is never fatal, but the ownership guard
+    exits the whole run, which would take llama.cpp inference down with it."""
+    guard = SETUP_PS1.split("function Assert-StudioOwnedOrAbsent", 1)[1].split("\nfunction ", 1)[0]
+    assert "[switch]$NonFatal" in guard
+    # Ordering, not just presence: below its exit the return is dead code.
+    paired = re.findall(
+        r'if \(\$NonFatal\) \{ return "Denied" \}\n\s*Exit-PathAccessDenied -Path \$Path', guard
+    )
+    assert len(paired) == guard.count("Exit-PathAccessDenied -Path $Path"), guard
+    # No unpaired return: one above the custom-home gate would call a fresh
+    # install unreadable.
+    assert len(paired) == guard.count('if ($NonFatal) { return "Denied" }'), guard
+    assert len(paired) >= 3, guard
+    # Only the denial is handed back; an unowned tree must still stop.
+    assert 'Exit-SetupFailure "$Label path is not an Unsloth-owned install' in guard
+    whisper = _whisper_phase()
+    assert '-Label "whisper.cpp install" -NonFatal) -eq "Denied"' in whisper, whisper
+    # Scoped to the new branch: both phrases occur elsewhere in the phase, so a
+    # phase-wide match proves nothing about this branch.
+    marker = '-NonFatal) -eq "Denied") {'
+    assert marker in whisper, whisper
+    denial = whisper.split(marker, 1)[1].split("\n} elseif", 1)[0]
+    assert re.search(r'^\s*step "whisper\.cpp" ', denial, re.M), denial
+    assert "install directory cannot be read: access is denied" in denial, denial
+    assert "browser and Transformers dictation remain available" in denial, denial
+    # The whole point is that this stays non-fatal.
+    assert "Exit-SetupFailure" not in denial, denial
+    assert not re.search(r"\bexit \d", denial), denial
+    # The skip must precede the branch whose guard would exit. Anchored on that
+    # branch's body, which survives a hardening of its own probe.
+    body = "$whisperArgs = @("
+    assert body in whisper, whisper
+    assert whisper.index("-NonFatal") < whisper.index(body)
+
+
+def test_the_whisper_skip_stays_behind_the_installer_gate():
+    """The guard used to live inside the installer branch, so a tree without the
+    installer was a no-op. Hoisting it must not make that case fatal."""
+    marker = "-NonFatal) -eq"
+    whisper = _whisper_phase()
+    assert marker in whisper, whisper
+    head = whisper.split(marker, 1)[0]
+    assert "} elseif" in head, head
+    branch = head.rsplit("} elseif", 1)[1]
+    # A conjunct, not merely present: -or or a negation reopens this case.
+    assert re.search(r"-and\s*\([^\n]*\$WhisperInstaller[^\n]*\)\s*-and", branch), branch
+    assert "-not (Test-Path" not in branch, branch
+    assert " -or " not in branch, branch