Crash on changelevel during the particles reset

[FreeSlave]

Calling delete particle changes the _particles vector (due to how the CMiniMem::Deallocate is implemented) thus invalidating the loop iterator.

halflife-updated/cl_dll/particleman/CMiniMem.cpp

Lines 213 to 217 in d2da2f1

	for (auto particle : _particles)
	{
	particle->Die();
	delete particle;
	}

To reproduce create some particles and change map while particles still exist.

[emreyn1]

bro how did you open the .exe file I couldn't see it on windows ! lmk if you have the same isssue

[SalsaAlex]

ran into this exact same issue, strangely this happens only with the last particle on the list

[FreeSlave]

In case you're wondering it can be fixed by iterating over a copy of _particles vector.

	auto particles = _particles;

	for (auto particle : particles)
	{
		particle->Die();
		delete particle;
	}

The copy is not being changed by the CBaseParticle destructor, so it's ok to iterate over.