refactor: move pin label validation from Chip to NormalComponent base class

Author: AnasSarkiz

lib/components/base-components/NormalComponent/NormalComponent.ts

@@ -49,6 +49,7 @@ import { Trace } from "lib/components/primitive-components/Trace/Trace"
 import { NormalComponent__getMinimumFlexContainerSize } from "./NormalComponent__getMinimumFlexContainerSize"
 import { NormalComponent__repositionOnPcb } from "./NormalComponent__repositionOnPcb"
 import { NormalComponent_doInitialSourceDesignRuleChecks } from "./NormalComponent_doInitialSourceDesignRuleChecks"
+import { filterPinLabels } from "lib/utils/filterPinLabels"
 
 const debug = Debug("tscircuit:core")
 
@@ -96,6 +97,8 @@ export class NormalComponent<
   pcb_missing_footprint_error_id?: string
   _hasStartedFootprintUrlLoad = false
 
+  private _invalidPinLabelMessages: string[] = []
+
   /**
    * Override this property for component defaults
    */
@@ -115,7 +118,20 @@ export class NormalComponent<
   }
 
   constructor(props: z.input<ZodProps>) {
-    super(props)
+    const filteredProps = { ...props }
+    let invalidPinLabelsMessages: string[] = []
+
+    // Apply invalid pin label filtering for object-based pinLabels only
+    // Array-based pinLabels (used by PinHeader) are left unfiltered
+    if (filteredProps.pinLabels && !Array.isArray(filteredProps.pinLabels)) {
+      const { validPinLabels, invalidPinLabelsMessages: messages } =
+        filterPinLabels(filteredProps.pinLabels)
+      filteredProps.pinLabels = validPinLabels
+      invalidPinLabelsMessages = messages
+    }
+
+    super(filteredProps)
+    this._invalidPinLabelMessages = invalidPinLabelsMessages
     this._addChildrenFromStringFootprint()
     this.initPorts()
   }
@@ -425,6 +441,26 @@ export class NormalComponent<
     if (this.root?.schematicDisabled) return
     const { db } = this.root!
 
+    // Insert warnings for invalid pin labels
+    if (this._invalidPinLabelMessages?.length && this.root?.db) {
+      for (const message of this._invalidPinLabelMessages) {
+        let property_name = "pinLabels"
+        const match = message.match(
+          /^Invalid pin label:\s*([^=]+)=\s*'([^']+)'/,
+        )
+        if (match) {
+          const label = match[2]
+          property_name = `pinLabels['${label}']`
+        }
+        this.root.db.source_property_ignored_warning.insert({
+          source_component_id: this.source_component_id!,
+          property_name,
+          message,
+          error_type: "source_property_ignored_warning",
+        })
+      }
+    }
+
     const { schematicSymbolName } = this.config
 
     if (schematicSymbolName) {

lib/components/normal-components/Chip.ts

@@ -3,30 +3,16 @@ import { NormalComponent } from "lib/components/base-components/NormalComponent"
 import { type SchematicBoxDimensions } from "lib/utils/schematic/getAllDimensionsForSchematicBox"
 import { Trace } from "lib/components/primitive-components/Trace/Trace"
 import { Port } from "lib/components/primitive-components/Port"
-import { filterPinLabels } from "lib/utils/filterPinLabels"
 import type { z } from "zod"
 
 export class Chip<PinLabels extends string = never> extends NormalComponent<
   typeof chipProps,
   PinLabels
 > {
   schematicBoxDimensions: SchematicBoxDimensions | null = null
-  private _invalidPinLabelMessages: string[] = []
 
   constructor(props: z.input<typeof chipProps>) {
-    const filteredProps = { ...props }
-    let invalidPinLabelsMessages: string[] = []
-
-    if (filteredProps.pinLabels) {
-      const { validPinLabels, invalidPinLabelsMessages: messages } =
-        filterPinLabels(filteredProps.pinLabels)
-      filteredProps.pinLabels = validPinLabels
-      invalidPinLabelsMessages = messages
-    }
-
-    // super needs to run before we can assign to `this`
-    super(filteredProps)
-    this._invalidPinLabelMessages = invalidPinLabelsMessages
+    super(props)
   }
 
   get config() {
@@ -90,25 +76,6 @@ export class Chip<PinLabels extends string = never> extends NormalComponent<
     // Early return if noSchematicRepresentation is true
     if (props?.noSchematicRepresentation === true) return
 
-    if (this._invalidPinLabelMessages?.length && this.root?.db) {
-      for (const message of this._invalidPinLabelMessages) {
-        let property_name = "pinLabels"
-        const match = message.match(
-          /^Invalid pin label:\s*([^=]+)=\s*'([^']+)'/,
-        )
-        if (match) {
-          const label = match[2]
-          property_name = `pinLabels['${label}']`
-        }
-        this.root.db.source_property_ignored_warning.insert({
-          source_component_id: this.source_component_id!,
-          property_name,
-          message,
-          error_type: "source_property_ignored_warning",
-        })
-      }
-    }
-
     // Continue with normal schematic rendering
     super.doInitialSchematicComponentRender()
   }