Skip to content

Commit 43bd26a

Browse files
SudipSinhaclaude
andcommitted
fix(prometheus): deprecated list/delete query by deprecated metric name
Parameterize list/delete functions to accept metric_name. Deprecated fouriermmd wrappers pass DEPRECATED_METRIC_NAME so scheduler queries match the stored request key. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Sudip Sinha <Sudip.Sinha@RedHat.com>
1 parent 3531305 commit 43bd26a

1 file changed

Lines changed: 10 additions & 6 deletions

File tree

  • src/endpoints/metrics/drift

src/endpoints/metrics/drift/mmd.py

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -247,7 +247,9 @@ async def schedule_mmd(request: MMDMetricRequest) -> dict[str, str]:
247247

248248

249249
@router.delete("/metrics/drift/mmd/request")
250-
async def delete_mmd_schedule(schedule: ScheduleId) -> dict[str, str]:
250+
async def delete_mmd_schedule(
251+
schedule: ScheduleId, metric_name: str = METRIC_NAME
252+
) -> dict[str, str]:
251253
"""Delete a recurring computation of MMD metric."""
252254
scheduler = get_prometheus_scheduler()
253255
if not scheduler:
@@ -265,7 +267,7 @@ async def delete_mmd_schedule(schedule: ScheduleId) -> dict[str, str]:
265267

266268
try:
267269
logger.info("Deleting %s schedule: %s", METRIC_NAME, schedule.requestId)
268-
await scheduler.delete(METRIC_NAME, request_uuid)
270+
await scheduler.delete(metric_name, request_uuid)
269271

270272
except HTTPException:
271273
raise
@@ -288,7 +290,9 @@ async def delete_mmd_schedule(schedule: ScheduleId) -> dict[str, str]:
288290

289291

290292
@router.get("/metrics/drift/mmd/requests")
291-
async def list_mmd_requests() -> dict[str, list[dict[str, Any]]]:
293+
async def list_mmd_requests(
294+
metric_name: str = METRIC_NAME,
295+
) -> dict[str, list[dict[str, Any]]]:
292296
"""List the currently scheduled computations of MMD metric."""
293297
scheduler = get_prometheus_scheduler()
294298
if not scheduler:
@@ -298,7 +302,7 @@ async def list_mmd_requests() -> dict[str, list[dict[str, Any]]]:
298302
)
299303

300304
try:
301-
requests = scheduler.get_requests(METRIC_NAME)
305+
requests = scheduler.get_requests(metric_name)
302306

303307
requests_list = []
304308
for request_id, request in requests.items():
@@ -411,7 +415,7 @@ async def delete_fouriermmd_schedule(schedule: ScheduleId) -> dict[str, str]:
411415
/metrics/drift/mmd/request instead.
412416
"""
413417
log_deprecated_endpoint(logger, DEPRECATED_METRIC_NAME, METRIC_NAME)
414-
return await delete_mmd_schedule(schedule)
418+
return await delete_mmd_schedule(schedule, metric_name=DEPRECATED_METRIC_NAME)
415419

416420

417421
@router.get("/metrics/drift/fouriermmd/requests", deprecated=True)
@@ -422,7 +426,7 @@ async def list_fouriermmd_requests() -> dict[str, list[dict[str, Any]]]:
422426
/metrics/drift/mmd/requests instead.
423427
"""
424428
log_deprecated_endpoint(logger, DEPRECATED_METRIC_NAME, METRIC_NAME)
425-
return await list_mmd_requests()
429+
return await list_mmd_requests(metric_name=DEPRECATED_METRIC_NAME)
426430

427431

428432
async def calculate_mmd_metric(

0 commit comments

Comments
 (0)