Skip to content

NAS-142371 / 27.0.0-BETA.1 / Migrate SMB share forms to tn-* form controls #3215

NAS-142371 / 27.0.0-BETA.1 / Migrate SMB share forms to tn-* form controls

NAS-142371 / 27.0.0-BETA.1 / Migrate SMB share forms to tn-* form controls #3215

Triggered via pull request August 27, 2026 10:24
Status Success
Total duration 9m 19s
Artifacts 1

claude.yml

on: pull_request
review  /  ...  /  Check member access
4s
review / check-member / Check member access
review  /  Automatic PR review
9m 9s
review / Automatic PR review
Fit to window
Zoom out
Zoom in

Annotations

2 warnings and 12 notices
review / check-member / Check member access
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v7. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
review / Automatic PR review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/upload-artifact@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
review / Automatic PR review: src/app/pages/sharing/smb/smb-form/smb-form.component.spec.ts#L565
LOW: Three new quota specs disable failOnConsole with a bare console.warn spy and no note of the expected warning, so a newly introduced warning would be swallowed
review / Automatic PR review: src/app/pages/sharing/smb/smb-form/smb-users-warning/smb-users-warning.component.scss#L9
LOW: color: var(--tn-warning) has no fallback and the token is defined only on ix-smb-form's host in another stylesheet, so the icon silently loses its warning colour if reused elsewhere
review / Automatic PR review: src/app/pages/sharing/iscsi/extent/extent-form/extent-form.component.html#L121
LOW: Comment keeps ix-input because tn-input InputType.Size rounds on blur, which this PR's library bump fixes; same stale rationale in device-form.component.html:72 and vm-edit-form.component.html:149
review / Automatic PR review
reviewer was denied Bash: node -e "const fs=require('fs');const f='/home/runner/work/webui/webui/src/app/pages/datasets/modules/permissions/components/edit-nfs-ace/edit-nfs-ace.component.spec.ts';fs.readFileSync(f,'utf8').split('\n').forEach((l,i)=>{if(l.length>120)console.log(f+':'+(i+1)+' len='+l.length)})"
review / Automatic PR review
reviewer was denied Bash: grep -n '^.\{121,\}$' /home/runner/work/webui/webui/src/app/pages/datasets/modules/permissions/components/edit-nfs-ace/edit-nfs-ace.component.spec.ts || echo NONE-OVER-120
review / Automatic PR review
reviewer was denied Bash: grep -rn '.\{121,\}' /home/runner/work/webui/webui/src/app/core/providers/tn-fallback-labels.provider.ts /home/runner/work/webui/webui/src/setup-jest.ts /home/runner/work/webui/webui/src/app/pages/sharing/smb/smb-form/smb-form.component.spec.ts
review / Automatic PR review
reviewer was denied Bash: grep -n '.\{121,\}' /home/runner/work/webui/webui/src/app/pages/datasets/modules/permissions/components/edit-nfs-ace/edit-nfs-ace.component.spec.ts
review / Automatic PR review
reviewer was denied Bash: awk 'length > 120 {print FILENAME": "FNR": len="length}' /home/runner/work/webui/webui/src/app/pages/datasets/modules/permissions/components/edit-nfs-ace/edit-nfs-ace.component.spec.ts /home/runner/work/webui/webui/src/app/pages/sharing/smb/smb-form/smb-form.component.spec.ts /home/runner/work/webui
review / Automatic PR review
reviewer was denied Bash: cd /home/runner/work/webui/webui && awk 'length > 120 {print FILENAME": "FNR": "length}' src/app/pages/datasets/modules/permissions/components/edit-nfs-ace/edit-nfs-ace.component.spec.ts src/app/pages/sharing/smb/smb-form/smb-form.component.spec.ts src/app/core/providers/tn-fallback-labels.provider.
review / Automatic PR review
reviewer was denied Bash: awk 'length > 120 {print FILENAME": "FNR": "length}' src/app/pages/datasets/modules/permissions/components/edit-nfs-ace/edit-nfs-ace.component.spec.ts src/app/pages/sharing/smb/smb-form/smb-form.component.spec.ts src/app/core/providers/tn-fallback-labels.provider.ts src/app/core/providers/tn-fallbac
review / Automatic PR review
reviewer was denied Bash: gh pr diff 13958 --patch > /tmp/pr.diff; wc -l /tmp/pr.diff; gh pr checks 13958 2>&1 | head -40
review / Automatic PR review
reviewer was denied Bash: cd /home/runner/work/webui/webui && gh pr diff 13958 --patch > /tmp/pr.diff; wc -l /tmp/pr.diff; git log --oneline -1; gh pr checks 13958 2>&1 | head -40

Artifacts

Produced during runtime
Name Size Digest
claude-review-transcript
182 KB
sha256:e785eab11ad27284cc50197c36bfd0ff0e21059cafa7b0920d6a59878d6d2d67