NAS-142373 / 27.0.0-BETA.1 / Migrate Sharing/iSCSI forms to tn-* form controls #3214
AlexKarpov98claude.yml
on: pull_request
review
/
...
/
Check member access
3s
review
/
Automatic PR review
11m 17s
Annotations
2 warnings and 14 notices
|
review / check-member / Check member access
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v7. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4, actions/upload-artifact@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review:
src/app/pages/vm/devices/device-form/device-form.component.html#L71
LOW: Comment justifying ix-input for volsize cites the tn-input InputType.Size blur re-parse defect that this PR's bump to 0.7.1 removes
|
|
review / Automatic PR review:
src/app/pages/vm/vm-edit-form/vm-edit-form.component.html#L148
LOW: Comment justifying ix-input for memory fields cites the tn-input InputType.Size blur re-parse defect that this PR's bump to 0.7.1 removes
|
|
review / Automatic PR review:
src/app/modules/forms/ix-forms/constants/tn-select-labels.constant.ts#L10
LOW: Docblock and SKILL.md state per-call-site [placeholder]/[noOptionsLabel] bindings are no longer needed, but ~45 templates outside iSCSI still bind them and were not updated
|
|
review / Automatic PR review:
src/app/pages/sharing/iscsi/initiator/initiator-form/initiator-form.component.ts#L144
LOW: translate.instant('Save')/('Cancel') on the translated() lambda parameter is invisible to ngx-translate-extract, so a future string added here would ship untranslated
|
|
review / Automatic PR review
reviewer was denied Bash: gh api repos/truenas/webui/actions/jobs/98482640635/logs
|
|
review / Automatic PR review
reviewer was denied Bash: gh run view 33061858067
|
|
review / Automatic PR review
reviewer was denied Bash: gh run view 33061858067 --log-failed | head -200
|
|
review / Automatic PR review
reviewer was denied Bash: gh api repos/truenas/webui/actions/jobs/98482640635/logs --cache 0 2>&1 | grep -inE "●|FAIL src|Tests: " | head -60
|
|
review / Automatic PR review
reviewer was denied Bash: gh run view --job 98482640635 --log-failed
|
|
review / Automatic PR review
reviewer was denied Bash: gh run view --job 98482640635 --log-failed 2>&1 | grep -iE "●|FAIL |Tests:|Suites:" | head -80
|
|
review / Automatic PR review
reviewer was denied Bash: ls /home/runner/work/webui/webui/node_modules 2>/dev/null | head -3; echo "exit=$?"
|
|
review / Automatic PR review
reviewer was denied Bash: ls /home/runner/work/webui/webui/node_modules/@truenas/ui-components/package.json 2>/dev/null && node -e "console.log(require('/home/runner/work/webui/webui/node_modules/@truenas/ui-components/package.json').version)"
|
|
review / Automatic PR review
reviewer was denied Bash: gh pr diff 13971 --patch > /tmp/pr.diff && grep '^diff --git' /tmp/pr.diff
|
|
review / Automatic PR review
reviewer was denied Bash: gh pr diff 13971 --patch > /tmp/pr.diff; wc -l /tmp/pr.diff; grep -c '^diff --git' /tmp/pr.diff
|
Artifacts
Produced during runtime
| Name | Size | Digest | |
|---|---|---|---|
|
claude-review-transcript
|
235 KB |
sha256:b4d807c9f1223bbecbffcb1efdae5832f8db53bd0aefaa939361a9c321246858
|
|