NAS-141479 / 27.0.0-BETA.1 / Migrate Sharing/Shared components slide-ins & modal-header to tn-* #3100
AlexKarpov98claude.yml
on: pull_request
review
/
...
/
Check member access
4s
review
/
Automatic PR review
9m 35s
Annotations
2 warnings and 3 notices
|
review / check-member / Check member access
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v7. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review:
src/app/pages/sharing/smb/smb-status/smb-status.component.ts#L53
LOW: activeTabIndex and onTabChange duplicate iscsi.component.ts verbatim, including the re-emit guard and -1 clamp; extract a shared routed-tabs helper
|
|
review / Automatic PR review:
src/app/pages/sharing/smb/smb-status/smb-status.component.html#L14
LOW: The role="tabpanel" div has no id/aria-controls, aria-labelledby or tabindex, so the tab-to-panel association mat-tab-nav-panel provided is lost
|
|
review / Automatic PR review:
src/app/pages/sharing/components/shares-dashboard/service-state-button/service-state-button.component.html#L20
LOW: While service() is undefined the span keeps role="img" but aria-label resolves to null, leaving an unnamed image with no text fallback in the accessibility tree
|