NAS-141477 / 27.0.0-BETA.1 / Migrate Sharing/iSCSI slide-ins & modal-header to tn-* #3095
AlexKarpov98claude.yml
on: pull_request
review
/
...
/
Check member access
4s
review
/
Automatic PR review
9m 0s
Annotations
3 errors, 2 warnings, and 3 notices
|
review / Automatic PR review
Process completed with exit code 1.
|
|
review / Automatic PR review
1 finding(s) at or above MEDIUM
|
|
review / Automatic PR review:
src/app/pages/sharing/iscsi/global-target-configuration/global-target-configuration.component.html#L1
MEDIUM: Comment claims Enter-key implicit submission routes through submit(), but the form now has no submit button and four blocking fields, so no submit event fires and the handler is unreachable.
|
|
review / check-member / Check member access
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/github-script@v7. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review
Node.js 20 is deprecated. The following actions target Node.js 20 but are being forced to run on Node.js 24: actions/checkout@v4. For more information see: https://github.blog/changelog/2025-09-19-deprecation-of-node-20-on-github-actions-runners/
|
|
review / Automatic PR review:
src/app/pages/sharing/iscsi/global-target-configuration/global-target-configuration.component.spec.ts#L149
LOW: Test name claims the service-enabled dispatch is conditional on a stopped service, but onSubmit() dispatches unconditionally and the overrideSelector setup is inert.
|
|
review / Automatic PR review:
src/app/pages/sharing/iscsi/target/target-form/target-form.component.spec.ts#L326
LOW: afterEach hardcodes a duplicate of the permissive validatePhysicalPortUniqueness default declared at line 117, with nothing enforcing the two stay equal.
|
|
review / Automatic PR review:
src/app/pages/sharing/iscsi/global-target-configuration/global-target-configuration.component.html#L3
LOW: (submit)="submit()" does not honour canSubmit(); SidePanelForm.submit() calls onSubmit() unconditionally, unlike IxFormComponent.onFormSubmit() and device-form on the same epic.
|